2 * Copyright (c) 2010-2023 Contributors to the openHAB project
4 * See the NOTICE file(s) distributed with this work for additional
7 * This program and the accompanying materials are made available under the
8 * terms of the Eclipse Public License 2.0 which is available at
9 * http://www.eclipse.org/legal/epl-2.0
11 * SPDX-License-Identifier: EPL-2.0
13 package org.openhab.binding.dsmr.internal.discovery;
15 import java.util.Collection;
16 import java.util.List;
17 import java.util.Map.Entry;
18 import java.util.Objects;
20 import java.util.stream.Collectors;
22 import org.eclipse.jdt.annotation.NonNullByDefault;
23 import org.eclipse.jdt.annotation.Nullable;
24 import org.openhab.binding.dsmr.internal.device.cosem.CosemObject;
25 import org.openhab.binding.dsmr.internal.device.cosem.CosemObjectType;
26 import org.openhab.binding.dsmr.internal.device.p1telegram.P1Telegram;
27 import org.openhab.binding.dsmr.internal.device.p1telegram.P1TelegramListener;
28 import org.openhab.binding.dsmr.internal.handler.DSMRBridgeHandler;
29 import org.openhab.binding.dsmr.internal.handler.DSMRMeterHandler;
30 import org.openhab.binding.dsmr.internal.meter.DSMRMeterDescriptor;
31 import org.openhab.binding.dsmr.internal.meter.DSMRMeterType;
32 import org.openhab.core.library.types.StringType;
33 import org.openhab.core.thing.Thing;
34 import org.openhab.core.thing.binding.ThingHandler;
35 import org.openhab.core.thing.binding.ThingHandlerService;
36 import org.slf4j.Logger;
37 import org.slf4j.LoggerFactory;
40 * This implements the discovery service for new DSMR Meters on an active DSMR bridge.
42 * @author M. Volaart - Initial contribution
43 * @author Hilbrand Bouwkamp - Refactored code to detect meters during actual discovery phase.
46 public class DSMRMeterDiscoveryService extends DSMRDiscoveryService implements P1TelegramListener, ThingHandlerService {
48 private final Logger logger = LoggerFactory.getLogger(DSMRMeterDiscoveryService.class);
51 * The {@link DSMRBridgeHandler} instance
53 private @NonNullByDefault({}) DSMRBridgeHandler dsmrBridgeHandler;
56 * Constructs a new {@link DSMRMeterDiscoveryService} attached to the give bridge handler.
58 * @param dsmrBridgeHandler The bridge handler this discovery service is attached to
60 public DSMRMeterDiscoveryService() {
62 this.i18nProvider = DSMRI18nProviderTracker.i18nProvider;
63 this.localeProvider = DSMRI18nProviderTracker.localeProvider;
67 public void deactivate() {
72 public @Nullable ThingHandler getThingHandler() {
73 return dsmrBridgeHandler;
77 public void setThingHandler(ThingHandler handler) {
78 if (handler instanceof DSMRBridgeHandler) {
79 dsmrBridgeHandler = (DSMRBridgeHandler) handler;
84 protected void startScan() {
85 logger.debug("Start discovery on existing DSMR bridge.");
86 dsmrBridgeHandler.setLenientMode(true);
87 dsmrBridgeHandler.registerDSMRMeterListener(this);
91 protected synchronized void stopScan() {
92 logger.debug("Stop discovery on existing DSMR bridge.");
93 dsmrBridgeHandler.setLenientMode(false);
95 dsmrBridgeHandler.unregisterDSMRMeterListener(this);
99 public void telegramReceived(P1Telegram telegram) {
100 if (logger.isDebugEnabled()) {
101 logger.debug("Detect meters from #{} objects", telegram.getCosemObjects().size());
103 final Entry<Collection<DSMRMeterDescriptor>, List<CosemObject>> detectedMeters = meterDetector
104 .detectMeters(telegram);
105 verifyUnregisteredCosemObjects(telegram, detectedMeters.getValue());
106 validateConfiguredMeters(dsmrBridgeHandler.getThing().getThings(),
107 detectedMeters.getKey().stream().map(md -> md.getMeterType()).collect(Collectors.toSet()));
108 detectedMeters.getKey().forEach(m -> meterDiscovered(m, dsmrBridgeHandler.getThing().getUID()));
111 protected void verifyUnregisteredCosemObjects(P1Telegram telegram, List<CosemObject> list) {
112 if (!list.isEmpty()) {
114 .anyMatch(e -> e.getType() == CosemObjectType.METER_EQUIPMENT_IDENTIFIER
115 && e.getCosemValues().entrySet().stream().anyMatch(
116 cv -> cv.getValue() instanceof StringType && cv.getValue().toString().isEmpty()))) {
117 // Unregistered meter detected. log to the user.
118 reportUnregisteredMeters();
120 reportUnrecognizedCosemObjects(list);
121 logger.info("There are unrecognized cosem values in the data received from the meter,"
122 + " which means some meters might not be detected. Please report your raw data as reference: {}",
123 telegram.getRawTelegram());
126 if (!telegram.getUnknownCosemObjects().isEmpty()) {
127 logger.info("There are unrecognized cosem values in the data received from the meter,"
128 + " which means you have values that can't be read by a channel: {}. Please report them and your raw data as reference: {}",
129 telegram.getUnknownCosemObjects().stream()
130 .map(e -> String.format("obis id:%s, value:%s", e.getKey(), e.getValue()))
131 .collect(Collectors.joining(", ")),
132 telegram.getRawTelegram());
137 * Called when Unrecognized cosem objects where found. This can be a bug or a new meter not yet supported.
139 * @param list Map with the unrecognized.
141 protected void reportUnrecognizedCosemObjects(List<CosemObject> list) {
142 list.forEach(c -> logger.info("Unrecognized cosem object '{}' found in the data: {}", c.getType(), c));
146 * Called when a meter equipment identifier is found that has an empty value. This
148 protected void reportUnregisteredMeters() {
150 "An unregistered meter has been found. Probably a new meter. Retry discovery once the meter is registered with the energy provider.");
154 * Validates if the meters configured by the user match with what is detected in the telegram. Some meters are a
155 * subset of other meters and therefore an invalid configured meter does work, but not all available data is
156 * available to the user.
158 * @param things The list of configured things
159 * @param configuredMeterTypes The set of meters detected in the telegram
161 private void validateConfiguredMeters(List<Thing> things, Set<DSMRMeterType> configuredMeterTypes) {
163 final Set<DSMRMeterType> configuredMeters = things.stream()
164 .map(Thing::getHandler)
165 .filter(DSMRMeterHandler.class::isInstance)
166 .map(DSMRMeterHandler.class::cast)
167 .map(DSMRMeterHandler::getMeterDescriptor)
168 .filter(Objects::nonNull)
169 .map(d -> d.getMeterType())
170 .collect(Collectors.toSet());
172 // Create list of all configured meters that are not in the detected list. If not empty meters might not be
173 // correctly configured.
174 final List<DSMRMeterType> invalidConfigured = configuredMeters.stream()
175 .filter(dm -> !configuredMeterTypes.contains(dm)).collect(Collectors.toList());
176 // Create a list of all detected meters not yet configured.
177 final List<DSMRMeterType> unconfiguredMeters = configuredMeterTypes.stream()
178 .filter(dm -> !configuredMeters.contains(dm)).collect(Collectors.toList());
180 if (!invalidConfigured.isEmpty()) {
181 reportConfigurationValidationResults(invalidConfigured, unconfiguredMeters);
186 * Called when the validation finds in inconsistency between configured meters.
188 * @param invalidConfigured The list of invalid configured meters
189 * @param unconfiguredMeters The list of meters that were detected, but not configured
191 protected void reportConfigurationValidationResults(List<DSMRMeterType> invalidConfigured,
192 List<DSMRMeterType> unconfiguredMeters) {
194 "Possible incorrect meters configured. These are configured: {}."
195 + "But the following unconfigured meters are found in the data received from the meter: {}",
196 invalidConfigured.stream().map(m -> m.name()).collect(Collectors.joining(", ")),
197 unconfiguredMeters.stream().map(m -> m.name()).collect(Collectors.joining(", ")));