]> git.basschouten.com Git - openhab-addons.git/commit
[modbus] Gain-offset profile (QuantityType support) and writing of individual bits...
authorSami Salonen <ssalonen@gmail.com>
Fri, 16 Apr 2021 20:59:55 +0000 (23:59 +0300)
committerGitHub <noreply@github.com>
Fri, 16 Apr 2021 20:59:55 +0000 (22:59 +0200)
commit265fd30ba157516f4366b2be9cf8b89b6e23f620
tree1d1901ea0ed840a725793e5414b10b0e188f4ca3
parentb42101addca43b75138bb1c2d15b8f9e2cae131c
[modbus] Gain-offset profile (QuantityType support) and writing of individual bits of holding registers (#9980)

* [modbus] gainOffset and bitMask profiles for working with modbus data

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] README trailing whitespaces

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] README and some final renaming

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] log error with incompatible units

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] gainOffset profile: test for incompatible unit

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] example renamed

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Remove unused fields

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] gainOffset profile: make configuration parameters optional

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] xml indentantion fix

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] static code analysis fixes

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Minor fixes for null checking

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] remove comment

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] bit profile README disclaimer with many commands

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Grammar fixes in README

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Fix bit profile UI configuration

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Bit profile: Added possibility to invert value on read/write

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] fix typo with explanation of inverted

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] bit profile: unit tests for inverted parameter

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] spotless:apply

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] static checker fixes

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] write bit feature in data thing

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* wip

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] resolve itest

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] fixes

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Remove bit profile

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Fix data thing readStart validation

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] readme fix

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Remove bit profile test

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Invalidate REFRESH data cache with cacheful writes

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] cleanup

- abort if command is not convertible to 0/1 (previously wrote the
  cached data)
- fail fast conditionals instead of deep if's

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] README Fix typo in example

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] fix data thing write when child of endpoint

Also added regression test

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* Update bundles/org.openhab.binding.modbus/src/main/resources/OH-INF/config/gainOffset.xml

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
* [modbus] performance-optimized logging

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] README: Removing xtend syntax hint, not needed anymore

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] generics typing added

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] dead code

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] avoid supressing generic type warnings

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] unnecessary generics

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] rename type parameter name

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] QU (short for quantity output) generic type instead of Q2

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Remove unused localization

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] profile constant visibility harmonized

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] spotless:apply

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
bundles/org.openhab.binding.modbus/README.md
bundles/org.openhab.binding.modbus/src/main/java/org/openhab/binding/modbus/handler/ModbusPollerThingHandler.java
bundles/org.openhab.binding.modbus/src/main/java/org/openhab/binding/modbus/internal/handler/ModbusDataThingHandler.java
bundles/org.openhab.binding.modbus/src/main/java/org/openhab/binding/modbus/internal/profiles/ModbusGainOffsetProfile.java [new file with mode: 0644]
bundles/org.openhab.binding.modbus/src/main/java/org/openhab/binding/modbus/internal/profiles/ModbusProfileFactory.java [new file with mode: 0644]
bundles/org.openhab.binding.modbus/src/main/java/org/openhab/binding/modbus/internal/profiles/ModbusProfiles.java [new file with mode: 0644]
bundles/org.openhab.binding.modbus/src/main/resources/OH-INF/config/gainOffset.xml [new file with mode: 0644]
bundles/org.openhab.binding.modbus/src/main/resources/OH-INF/thing/thing-data.xml
bundles/org.openhab.binding.modbus/src/test/java/org/openhab/binding/modbus/internal/profiles/ModbusGainOffsetProfileTest.java [new file with mode: 0644]
itests/org.openhab.binding.modbus.tests/itest.bndrun
itests/org.openhab.binding.modbus.tests/src/main/java/org/openhab/binding/modbus/tests/ModbusDataHandlerTest.java