]> git.basschouten.com Git - openhab-addons.git/commit
[opensprinkler] Improvements: Remove apache.commons, fix bugs and warnings (#9869)
authorMatthew Skinner <matt@pcmus.com>
Sun, 11 Jul 2021 07:40:29 +0000 (17:40 +1000)
committerGitHub <noreply@github.com>
Sun, 11 Jul 2021 07:40:29 +0000 (09:40 +0200)
commit6fc24e4aa4491342cc0cc02761ae842c654f615f
tree493f69137e764ea9cc17c024767191e2c6f55798
parent1e8be24fce0fbb96f92fe28399b6cb24f13562c1
[opensprinkler] Improvements: Remove apache.commons, fix bugs and warnings (#9869)

* Fix: current channel would not get added.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Fix: online and offline now detect correctly.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Improve discovery.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Bug fixes.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Misc Improvements and log cleanup.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Make current sensor channel dynamically get removed if not supported.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* fix compiler warning.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* readme updates.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Shift refresh()

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Add RSSI and water flow meter count channels.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Change to flowSensorCount

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Fix bug

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Fix NPE on parsing jsReplies.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Add new programs channel.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Fix wrong api use.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Change to using max time if the time is null.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Add device withRepresentationProperty

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* update readme

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Fix rain sensor not working in 219 firmware.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Spotless fixes.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* fix gson double up error.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Add more channels

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* refresh completed before bridge goes online.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Simplify.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Allow non default password to not stop discovery.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Add ignoresRain channel

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Simplify commands in station handler.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Add new rainDelay channel.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Make constants consistent.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Add categories.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Changes requested by FlorianSW

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Stop catching and throwing new exp.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Create a state class.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Update bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/discovery/OpenSprinklerDiscoveryService.java

Signed-off-by: Matthew Skinner <matt@pcmus.com>
Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
* Fix for EOF exception that stops polling with bad wifi.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Change signal strength over to 0-4 range

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Handle toUnit null returns.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Support discovery on subnets that are not /24

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* update readme for recent changes to signalStrength channel.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Fix code anal issue and readme.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Remove info logging.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* remove traces of old dependancy.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Changes for fwolter

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* support RSSI and rssi

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Update after new command sent.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* improve delayedRefresh

Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Remove supressWarnings

Signed-off-by: Matthew Skinner <matt@pcmus.com>
Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
40 files changed:
bundles/org.openhab.binding.opensprinkler/README.md
bundles/org.openhab.binding.opensprinkler/pom.xml
bundles/org.openhab.binding.opensprinkler/src/main/feature/feature.xml
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/OpenSprinklerBindingConstants.java
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/OpenSprinklerHandlerFactory.java
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/OpenSprinklerState.java [new file with mode: 0644]
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/OpenSprinklerStateDescriptionProvider.java [new file with mode: 0644]
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/api/OpenSprinklerApi.java
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/api/OpenSprinklerApiConstants.java [deleted file]
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/api/OpenSprinklerApiFactory.java
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/api/OpenSprinklerHttpApiV100.java
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/api/OpenSprinklerHttpApiV210.java
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/api/OpenSprinklerHttpApiV213.java
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/api/OpenSprinklerHttpApiV217.java [new file with mode: 0644]
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/api/OpenSprinklerHttpApiV219.java [new file with mode: 0644]
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/api/exception/CommunicationApiException.java
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/api/exception/DataFormatErrorApiException.java
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/api/exception/DataMissingApiException.java
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/api/exception/GeneralApiException.java
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/api/exception/MismatchApiException.java
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/api/exception/NotPermittedApiException.java
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/api/exception/OutOfRangeApiException.java
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/api/exception/PageNotFoundApiException.java
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/api/exception/UnauthorizedApiException.java
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/api/exception/UnknownApiException.java
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/config/OpenSprinklerHttpInterfaceConfig.java
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/config/OpenSprinklerPiConfig.java
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/config/OpenSprinklerStationConfig.java
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/discovery/OpenSprinklerDiscoveryJob.java
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/discovery/OpenSprinklerDiscoveryService.java
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/handler/OpenSprinklerBaseBridgeHandler.java [deleted file]
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/handler/OpenSprinklerBaseHandler.java
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/handler/OpenSprinklerDeviceHandler.java
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/handler/OpenSprinklerHttpBridgeHandler.java
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/handler/OpenSprinklerStationHandler.java
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/model/NoCurrentDrawSensorException.java [deleted file]
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/model/StationProgram.java
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/util/Hash.java
bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/util/Parse.java
bundles/org.openhab.binding.opensprinkler/src/main/resources/OH-INF/thing/thing-types.xml