]> git.basschouten.com Git - openhab-addons.git/commit
[neohub] Quality improvements (#10522)
authorAndrew Fiddian-Green <software@whitebear.ch>
Mon, 19 Apr 2021 18:39:12 +0000 (19:39 +0100)
committerGitHub <noreply@github.com>
Mon, 19 Apr 2021 18:39:12 +0000 (20:39 +0200)
commit858ef65aef0f0ed18fb969ea90050f9adc1be34e
tree40e797b600ee7c549288ebcd720892a945cf2e91
parentada54dbcfa7e93a433df39de15747ee423e0af4a
[neohub] Quality improvements (#10522)

* [neohub] eliminate once in a blue moon fin-ack fin-ack issues

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* Revert "[neohub] eliminate once in a blue moon fin-ack fin-ack issues"

This reverts commit 022513ee85878f2f9cf2fd27fa3d79d251197c5a.

* [neohub] extra hub properties; hub id in logs (help for multiple hubs)

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] run spotless

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] getFirmwareVersion returns null for unknown

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] api version enum; tweaked logging

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] fix mvn warning

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] cosmetic for diff

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] device info property, and comments

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] tweaks to fin-ack sequence

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] eliminate irrelevant compiler warnings, and live test errors

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] avert merge conflict with #10525

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] apply changes in anticipation of reviewer approval

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
bundles/org.openhab.binding.neohub/src/main/java/org/openhab/binding/neohub/internal/NeoBaseHandler.java
bundles/org.openhab.binding.neohub/src/main/java/org/openhab/binding/neohub/internal/NeoHubBindingConstants.java
bundles/org.openhab.binding.neohub/src/main/java/org/openhab/binding/neohub/internal/NeoHubHandler.java
bundles/org.openhab.binding.neohub/src/main/java/org/openhab/binding/neohub/internal/NeoHubHandlerFactory.java
bundles/org.openhab.binding.neohub/src/main/java/org/openhab/binding/neohub/internal/NeoHubReadDcbResponse.java
bundles/org.openhab.binding.neohub/src/main/java/org/openhab/binding/neohub/internal/NeoHubSocket.java
bundles/org.openhab.binding.neohub/src/test/java/org/openhab/binding/neohub/test/NeoHubTestData.java