]> git.basschouten.com Git - openhab-addons.git/commit
[smhi] Fix exception in aggregation function when daily forecast is empty (#10851)
authorAnders Alfredsson <30875102+pacive@users.noreply.github.com>
Tue, 15 Jun 2021 21:56:50 +0000 (23:56 +0200)
committerGitHub <noreply@github.com>
Tue, 15 Jun 2021 21:56:50 +0000 (23:56 +0200)
commitc9933454db89c76f0df1524c3af76a186b388e52
treeaf4a1269bdd008f180662bc8aafb3f0d34c22369
parentc21c468cac2fc99d755b3bfabf2a2f91ede95407
[smhi] Fix exception in aggregation function when daily forecast is empty (#10851)

* Fix exception in aggregation function when daily forecast is empty

Also catch any Exception to prevent thread from crashing

Signed-off-by: Anders Alfredsson <andersb86@gmail.com>
* Refactor to improve robustness of calculations

Improve tests to cover different forecast scenarios

Signed-off-by: Anders Alfredsson <andersb86@gmail.com>
bundles/org.openhab.binding.smhi/src/main/java/org/openhab/binding/smhi/internal/ForecastAggregator.java
bundles/org.openhab.binding.smhi/src/main/java/org/openhab/binding/smhi/internal/SmhiHandler.java
bundles/org.openhab.binding.smhi/src/main/java/org/openhab/binding/smhi/internal/TimeSeries.java
bundles/org.openhab.binding.smhi/src/test/java/org/openhab/binding/smhi/internal/SmhiTest.java
bundles/org.openhab.binding.smhi/src/test/resources/org/openhab/binding/smhi/internal/forecast.json [deleted file]
bundles/org.openhab.binding.smhi/src/test/resources/org/openhab/binding/smhi/internal/forecast1.json [new file with mode: 0644]
bundles/org.openhab.binding.smhi/src/test/resources/org/openhab/binding/smhi/internal/forecast2.json [new file with mode: 0644]
bundles/org.openhab.binding.smhi/src/test/resources/org/openhab/binding/smhi/internal/forecast3.json [new file with mode: 0644]