]> git.basschouten.com Git - openhab-addons.git/commit
projects / openhab-addons.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 8b3bb31) | patch
[hdpowerview] Refactor dynamic channels (#11853)
authorJacob Laursen <jacob-github@vindvejr.dk>
Mon, 17 Jan 2022 12:41:33 +0000 (13:41 +0100)
committerGitHub <noreply@github.com>
Mon, 17 Jan 2022 12:41:33 +0000 (13:41 +0100)
commite44dfe7dbcdb478574c575052b5a1948d36bde0a
tree6fb72083530de6fe088a08f431cf7a103f3bec2dtree | snapshot
parent8b3bb313eb229304b061c65a9da0ae51bed86ab8commit | diff
[hdpowerview] Refactor dynamic channels (#11853)

* Extract dynamic channel creation to separate classes.
* Avoid double list allocations.
* Add test coverage for scenarios with no channels built.
* Extract common builder stuff to super class.
* Fix grammar.
* Reduce constructor access modifiers.
* Removed unneeded this keyword for protected method.
* Fix null annotation issues.

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
13 files changed:
bundles/org.openhab.binding.hdpowerview/src/main/java/org/openhab/binding/hdpowerview/internal/builders/AutomationChannelBuilder.java [new file with mode: 0644] blob
bundles/org.openhab.binding.hdpowerview/src/main/java/org/openhab/binding/hdpowerview/internal/builders/BaseChannelBuilder.java [new file with mode: 0644] blob
bundles/org.openhab.binding.hdpowerview/src/main/java/org/openhab/binding/hdpowerview/internal/builders/SceneChannelBuilder.java [new file with mode: 0644] blob
bundles/org.openhab.binding.hdpowerview/src/main/java/org/openhab/binding/hdpowerview/internal/builders/SceneGroupChannelBuilder.java [new file with mode: 0644] blob
bundles/org.openhab.binding.hdpowerview/src/main/java/org/openhab/binding/hdpowerview/internal/handler/HDPowerViewHubHandler.java diff | blob | history
bundles/org.openhab.binding.hdpowerview/src/main/resources/OH-INF/i18n/hdpowerview.properties diff | blob | history
bundles/org.openhab.binding.hdpowerview/src/main/resources/OH-INF/i18n/hdpowerview_da.properties diff | blob | history
bundles/org.openhab.binding.hdpowerview/src/main/resources/OH-INF/thing/thing-types.xml diff | blob | history
bundles/org.openhab.binding.hdpowerview/src/test/java/org/openhab/binding/hdpowerview/AutomationChannelBuilderTest.java [new file with mode: 0644] blob
bundles/org.openhab.binding.hdpowerview/src/test/java/org/openhab/binding/hdpowerview/LocaleProviderForTests.java [new file with mode: 0644] blob
bundles/org.openhab.binding.hdpowerview/src/test/java/org/openhab/binding/hdpowerview/SceneChannelBuilderTest.java [new file with mode: 0644] blob
bundles/org.openhab.binding.hdpowerview/src/test/java/org/openhab/binding/hdpowerview/SceneGroupChannelBuilderTest.java [new file with mode: 0644] blob
bundles/org.openhab.binding.hdpowerview/src/test/java/org/openhab/binding/hdpowerview/TranslationProviderForTests.java [new file with mode: 0644] blob
Unnamed repository; edit this file 'description' to name the repository.