]> git.basschouten.com Git - openhab-addons.git/commit
[caddx] Fix wrongly handled discovery, off by 1 errors (#9030)
authorGeorgios Moutsos <50378548+jossuar@users.noreply.github.com>
Thu, 19 Nov 2020 02:10:09 +0000 (04:10 +0200)
committerGitHub <noreply@github.com>
Thu, 19 Nov 2020 02:10:09 +0000 (18:10 -0800)
commitfa21dff364bc82fd9b305911612e1d5ca013fe8a
treeef077102fd19a17cd32ac07d3f7801475a3da63e
parent6e3c6400434f0f490a1d4aaeafb4f1cb15d0368c
[caddx] Fix wrongly handled discovery, off by 1 errors (#9030)

* Corrected caddx discovery bug
* Maintenance

- Changed refresh logic for the things
- Code cleanup
- Corrected off by one errors
- Added initial tests for the message parsing
* Corrected ParameterizedTest
* Changed new Date().getTime to System.currentTimeMillis()

Signed-off-by: Georgios Moutsos <georgios.moutsos@gmail.com>
13 files changed:
bundles/org.openhab.binding.caddx/README.md
bundles/org.openhab.binding.caddx/src/main/java/org/openhab/binding/caddx/internal/CaddxMessage.java
bundles/org.openhab.binding.caddx/src/main/java/org/openhab/binding/caddx/internal/CaddxProperty.java
bundles/org.openhab.binding.caddx/src/main/java/org/openhab/binding/caddx/internal/config/CaddxBridgeConfiguration.java
bundles/org.openhab.binding.caddx/src/main/java/org/openhab/binding/caddx/internal/handler/CaddxBridgeHandler.java
bundles/org.openhab.binding.caddx/src/main/java/org/openhab/binding/caddx/internal/handler/ThingHandlerPanel.java
bundles/org.openhab.binding.caddx/src/main/java/org/openhab/binding/caddx/internal/handler/ThingHandlerPartition.java
bundles/org.openhab.binding.caddx/src/main/java/org/openhab/binding/caddx/internal/handler/ThingHandlerZone.java
bundles/org.openhab.binding.caddx/src/main/resources/OH-INF/thing/bridge.xml
bundles/org.openhab.binding.caddx/src/test/java/org/openhab/binding/caddx/internal/CaddxMessageReaderUtil.java [new file with mode: 0644]
bundles/org.openhab.binding.caddx/src/test/java/org/openhab/binding/caddx/internal/message/CaddxMessageParseTest.java [new file with mode: 0644]
bundles/org.openhab.binding.caddx/src/test/resources/org/openhab/binding/caddx/internal/interface_configuration_message.msg [new file with mode: 0644]
bundles/org.openhab.binding.caddx/src/test/resources/org/openhab/binding/caddx/internal/zone_status_message.msg [new file with mode: 0644]