]> git.basschouten.com Git - openhab-addons.git/commit
[modbus] fix defaults for tcp and serial things and some other minor cleanup (#10147)
authorSami Salonen <ssalonen@gmail.com>
Wed, 17 Feb 2021 10:41:40 +0000 (12:41 +0200)
committerGitHub <noreply@github.com>
Wed, 17 Feb 2021 10:41:40 +0000 (11:41 +0100)
commitfbf55d5886a4a6440645acd2768a5d1a4ecd93e5
tree2096599d8d58fc29bf02427ac1061b52937cb67a
parentfe496c73893cc05d2dad4b1e8297fc66be4fb7dc
[modbus] fix defaults for tcp and serial things and some other minor cleanup (#10147)

* [modbus] More strict nullness. Remove apache.commons.lang from itests
* [modbus] Defaults for tcp and serial things according to docs
* [modbus] further explicit defaults
* [modbus] document default encoding for serial.
RTU is pretty much the only one used in the field.
Previous default was ascii implicitly.
* [modbus] verify defaults are used for undefined configuration parameters

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
bundles/org.openhab.binding.modbus/README.md
bundles/org.openhab.binding.modbus/src/main/java/org/openhab/binding/modbus/internal/config/ModbusSerialConfiguration.java
bundles/org.openhab.binding.modbus/src/main/java/org/openhab/binding/modbus/internal/config/ModbusTcpConfiguration.java
bundles/org.openhab.binding.modbus/src/main/java/org/openhab/binding/modbus/internal/handler/AbstractModbusEndpointThingHandler.java
itests/org.openhab.binding.modbus.tests/itest.bndrun
itests/org.openhab.binding.modbus.tests/src/main/java/org/openhab/binding/modbus/tests/AbstractModbusOSGiTest.java
itests/org.openhab.binding.modbus.tests/src/main/java/org/openhab/binding/modbus/tests/ModbusTcpThingHandlerTest.java