]> git.basschouten.com Git - openhab-addons.git/commitdiff
[feed] Try to make tests more stable (#9315)
authorFabian Wolter <github@fabian-wolter.de>
Sat, 12 Dec 2020 18:30:28 +0000 (19:30 +0100)
committerGitHub <noreply@github.com>
Sat, 12 Dec 2020 18:30:28 +0000 (19:30 +0100)
Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
itests/org.openhab.binding.feed.tests/src/main/java/org/openhab/binding/feed/test/FeedHandlerTest.java

index 258393dc86b51b5b0c9bf8277a6e96292186e99b..1e3d250152a59b5f342ccb49ba6b37bd24c7b9b9 100644 (file)
@@ -104,6 +104,7 @@ public class FeedHandlerTest extends JavaOSGiTest {
     private Thing feedThing;
     private FeedHandler feedHandler;
     private ChannelUID channelUID;
+    private HttpService httpService;
 
     /**
      * This class is used as a mock for HTTP web server, serving XML feed content.
@@ -175,9 +176,8 @@ public class FeedHandlerTest extends JavaOSGiTest {
         });
     }
 
-    private void registerFeedTestServlet() {
-        HttpService httpService = getService(HttpService.class);
-        assertThat(httpService, is(notNullValue()));
+    private synchronized void registerFeedTestServlet() {
+        waitForAssert(() -> assertThat(httpService = getService(HttpService.class), is(notNullValue())));
         servlet = new FeedServiceMock(DEFAULT_MOCK_CONTENT);
         try {
             httpService.registerServlet(MOCK_SERVLET_PATH, servlet, null, null);
@@ -186,9 +186,8 @@ public class FeedHandlerTest extends JavaOSGiTest {
         }
     }
 
-    private void unregisterFeedTestServlet() {
-        HttpService httpService = getService(HttpService.class);
-        assertThat(httpService, is(notNullValue()));
+    private synchronized void unregisterFeedTestServlet() {
+        waitForAssert(() -> assertThat(httpService = getService(HttpService.class), is(notNullValue())));
         httpService.unregister(MOCK_SERVLET_PATH);
         servlet = null;
     }