[gardena] remove compiler warnings (#12947)

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>

diff --git a/bundles/org.openhab.binding.gardena/README.md b/bundles/org.openhab.binding.gardena/README.md
index 48a2f88427c6902816e4cd495b4709b190e9c016..21e7c3562430f7eb37f59cdf4eebb07f777e750e 100644 (file)
--- a/bundles/org.openhab.binding.gardena/README.md
+++ b/bundles/org.openhab.binding.gardena/README.md
@@ -108,6 +108,7 @@ openhab:send WC_Valve_cmd_CloseValve.sendCommand(ON) // stop any active watering
 ```
 
 If you send a REFRESH command to the last update timestamp (no matter which thing), **ALL** items from **ALL** things are updated
+
 ```
 DateTime LastUpdate "LastUpdate [%1$td.%1$tm.%1$tY %1$tH:%1$tM]" { channel="gardena:water_control:home:myWateringComputer:common#lastUpdate_timestamp" }
 

diff --git a/bundles/org.openhab.binding.gardena/src/main/java/org/openhab/binding/gardena/internal/model/dto/Device.java b/bundles/org.openhab.binding.gardena/src/main/java/org/openhab/binding/gardena/internal/model/dto/Device.java
index 4514a67fc70cb69ff9ac10e6a5463793edd6448d..6c6d091deefc436280163662b7119bb6f613e8c9 100644 (file)
--- a/bundles/org.openhab.binding.gardena/src/main/java/org/openhab/binding/gardena/internal/model/dto/Device.java
+++ b/bundles/org.openhab.binding.gardena/src/main/java/org/openhab/binding/gardena/internal/model/dto/Device.java
@@ -126,8 +126,7 @@ public class Device {
             valveSet = (ValveSetServiceDataItem) dataItem;
         } else if (dataItem instanceof ValveServiceDataItem) {
             String valveNumber = StringUtils.substringAfterLast(dataItem.id, ":");
-            if (valveNumber != null
-                    && (valveNumber.equals("") || valveNumber.equals("wc") || valveNumber.equals("0"))) {
+            if ("".equals(valveNumber) || "wc".equals(valveNumber) || "0".equals(valveNumber)) {
                 valve = (ValveServiceDataItem) dataItem;
             } else if ("1".equals(valveNumber)) {
                 valveOne = (ValveServiceDataItem) dataItem;