]> git.basschouten.com Git - openhab-addons.git/commitdiff
damp factor default value (#16818)
authorBernd Weymann <bernd.weymann@gmail.com>
Tue, 28 May 2024 18:43:29 +0000 (20:43 +0200)
committerGitHub <noreply@github.com>
Tue, 28 May 2024 18:43:29 +0000 (20:43 +0200)
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
bundles/org.openhab.binding.solarforecast/README.md
bundles/org.openhab.binding.solarforecast/src/main/java/org/openhab/binding/solarforecast/internal/forecastsolar/config/ForecastSolarPlaneConfiguration.java
bundles/org.openhab.binding.solarforecast/src/main/resources/OH-INF/config/fs-plane-config.xml

index 8378ef4a032d0fe02249a17fc695ea5a5881104b..be93564f39f164e6ee1fbac7212b46cd42e99486 100644 (file)
@@ -113,8 +113,8 @@ In case of empty the location configured in openHAB is obtained.
 | declination     | integer | Plane Declination: 0 for horizontal till 90 for vertical declination         | N/A     | yes      | false    |
 | azimuth         | integer | Plane Azimuth: -180 = north, -90 = east, 0 = south, 90 = west, 180 = north   | N/A     | yes      | false    |
 | kwp             | decimal | Installed Kilowatt Peak                                                      | N/A     | yes      | false    |
-| dampAM          | decimal | Damping factor of morning hours                                              | 0.25    | no       | true     |
-| dampPM          | decimal | Damping factor of evening hours                                              | 0.25    | no       | true     |
+| dampAM          | decimal | Damping factor of morning hours                                              | 0       | no       | true     |
+| dampPM          | decimal | Damping factor of evening hours                                              | 0       | no       | true     |
 | horizon         | text    | Horizon definition as comma separated integer values                         | N/A     | no       | true     |
 
 `refreshInterval` of forecast data needs to respect the throttling of the ForecastSolar service. 
index ed2da9a384bb1869e6de9ea0f507b3fb028bd8e0..fa68d282b9ee899a03df10ab395f25af014fed4c 100644 (file)
@@ -26,7 +26,7 @@ public class ForecastSolarPlaneConfiguration {
     public int azimuth = -1;
     public double kwp = 0;
     public long refreshInterval = 30;
-    public double dampAM = 0.25;
-    public double dampPM = 0.25;
+    public double dampAM = 0;
+    public double dampPM = 0;
     public String horizon = SolarForecastBindingConstants.EMPTY;
 }
index 3e413fcb328f561d6c473d160373c06e780adacd..7431cb98f7c2a462e35b64f51099b30c881a4dd7 100644 (file)
                <parameter name="dampAM" type="decimal" step="0.01" min="0" max="1">
                        <label>Morning Damping Factor</label>
                        <description>Damping factor of morning hours</description>
-                       <default>0.25</default>
+                       <default>0</default>
                        <advanced>true</advanced>
                </parameter>
                <parameter name="dampPM" type="decimal" step="0.01" min="0" max="1">
                        <label>Evening Damping Factor</label>
                        <description>Damping factor of evening hours</description>
-                       <default>0.25</default>
+                       <default>0</default>
                        <advanced>true</advanced>
                </parameter>
                <parameter name="horizon" type="text">