[homekit] update AuthInfo objects when blockUserDeletion changes (#14017)

* [homekit] update AuthInfo objects when blockUserDeletion changes

Signed-off-by: Cody Cutrer <cody@cutrer.us>
* [homekit] general cleanup of redundant method call and unused local vars

Signed-off-by: Cody Cutrer <cody@cutrer.us>
Signed-off-by: Cody Cutrer <cody@cutrer.us>

diff --git a/bundles/org.openhab.io.homekit/src/main/java/org/openhab/io/homekit/internal/HomekitAuthInfoImpl.java b/bundles/org.openhab.io.homekit/src/main/java/org/openhab/io/homekit/internal/HomekitAuthInfoImpl.java
index ba538f8a7cc471380b963c6f3fbbac305bfa1f83..941081150f147015555b4a7dc646ab330d6be784 100644 (file)
--- a/bundles/org.openhab.io.homekit/src/main/java/org/openhab/io/homekit/internal/HomekitAuthInfoImpl.java
+++ b/bundles/org.openhab.io.homekit/src/main/java/org/openhab/io/homekit/internal/HomekitAuthInfoImpl.java
@@ -57,6 +57,10 @@ public class HomekitAuthInfoImpl implements HomekitAuthInfo {
         initializeStorage();
     }
 
+    public void setBlockUserDeletion(boolean blockUserDeletion) {
+        this.blockUserDeletion = blockUserDeletion;
+    }
+
     @Override
     public void createUser(String username, byte[] publicKey) {
         logger.trace("create user {}", username);

diff --git a/bundles/org.openhab.io.homekit/src/main/java/org/openhab/io/homekit/internal/HomekitImpl.java b/bundles/org.openhab.io.homekit/src/main/java/org/openhab/io/homekit/internal/HomekitImpl.java
index 7e4da4a9ac1fe30dd3ae596fc85651132469664f..8353bedc121b2bb54dc61789b57e563ea5536fca 100644 (file)
--- a/bundles/org.openhab.io.homekit/src/main/java/org/openhab/io/homekit/internal/HomekitImpl.java
+++ b/bundles/org.openhab.io.homekit/src/main/java/org/openhab/io/homekit/internal/HomekitImpl.java
@@ -171,6 +171,11 @@ public class HomekitImpl implements Homekit, NetworkAddressChangeListener, Ready
                 for (HomekitChangeListener changeListener : changeListeners) {
                     changeListener.updateSettings(settings);
                 }
+                if (settings.blockUserDeletion != oldSettings.blockUserDeletion) {
+                    for (HomekitAuthInfoImpl authInfo : authInfos) {
+                        authInfo.setBlockUserDeletion(settings.blockUserDeletion);
+                    }
+                }
             }
         } catch (IOException | InvalidAlgorithmParameterException e) {
             logger.warn("could not initialize HomeKit bridge: {}", e.getMessage());
@@ -203,10 +208,6 @@ public class HomekitImpl implements Homekit, NetworkAddressChangeListener, Ready
         changeListener.setBridge(bridge);
         bridges.add(bridge);
         bridge.setConfigurationIndex(changeListener.getConfigurationRevision());
-        bridge.refreshAuthInfo();
-
-        final int lastAccessoryCount = changeListener.getLastAccessoryCount();
-        int currentAccessoryCount = changeListener.getAccessories().size();
         bridge.start();
         return bridge;
     }