[wolfsmartset] Fix NullPointerException when updating values (#11931)

* fix bug #11930 NullPointerException

Signed-off-by: Bo Biene <openhab.github@biene.eu>

diff --git a/bundles/org.openhab.binding.wolfsmartset/src/main/java/org/openhab/binding/wolfsmartset/internal/dto/GetParameterValuesDTO.java b/bundles/org.openhab.binding.wolfsmartset/src/main/java/org/openhab/binding/wolfsmartset/internal/dto/GetParameterValuesDTO.java
index bab0e0a746efb05f56f0f0222614cd3d15f2976b..60305d5816c1e1e860c916961bb8a55c527dfc38 100644 (file)
--- a/bundles/org.openhab.binding.wolfsmartset/src/main/java/org/openhab/binding/wolfsmartset/internal/dto/GetParameterValuesDTO.java
+++ b/bundles/org.openhab.binding.wolfsmartset/src/main/java/org/openhab/binding/wolfsmartset/internal/dto/GetParameterValuesDTO.java
@@ -53,8 +53,8 @@ public class GetParameterValuesDTO {
         this.values = values;
     }
 
-    public Boolean getIsNewJobCreated() {
-        return isNewJobCreated;
+    public boolean getIsNewJobCreated() {
+        return isNewJobCreated != null ? isNewJobCreated : false;
     }
 
     public void setIsNewJobCreated(Boolean isNewJobCreated) {

diff --git a/bundles/org.openhab.binding.wolfsmartset/src/main/java/org/openhab/binding/wolfsmartset/internal/handler/WolfSmartsetUnitThingHandler.java b/bundles/org.openhab.binding.wolfsmartset/src/main/java/org/openhab/binding/wolfsmartset/internal/handler/WolfSmartsetUnitThingHandler.java
index 47332440f6a9088a11aa448cad374a773f86cb3a..8a6d69f96c1ebd308e19939f8bb51fc06ad62370 100644 (file)
--- a/bundles/org.openhab.binding.wolfsmartset/src/main/java/org/openhab/binding/wolfsmartset/internal/handler/WolfSmartsetUnitThingHandler.java
+++ b/bundles/org.openhab.binding.wolfsmartset/src/main/java/org/openhab/binding/wolfsmartset/internal/handler/WolfSmartsetUnitThingHandler.java
@@ -184,7 +184,7 @@ public class WolfSmartsetUnitThingHandler extends BaseThingHandler {
      */
     public void updateValues(@Nullable GetParameterValuesDTO values) {
         var thingId = thing.getUID();
-        if (values != null && values.getValues() != null && values.getValues().size() > 0) {
+        if (values != null && values.getValues() != null && !values.getValues().isEmpty()) {
             if (!values.getIsNewJobCreated()) {
                 lastRefreshTime = Instant.now();
             }