]> git.basschouten.com Git - openhab-addons.git/commitdiff
[mielecloud] Fix tests by adding missing email configuration parameter (#12056)
authorWouter Born <github@maindrain.net>
Sat, 15 Jan 2022 20:27:59 +0000 (21:27 +0100)
committerGitHub <noreply@github.com>
Sat, 15 Jan 2022 20:27:59 +0000 (21:27 +0100)
The validation did not fail previously because it was broken and fixed in https://github.com/openhab/openhab-core/pull/2683

Signed-off-by: Wouter Born <github@maindrain.net>
itests/org.openhab.binding.mielecloud.tests/src/main/java/org/openhab/binding/mielecloud/internal/handler/MieleBridgeHandlerTest.java

index dced3f4fc4fd6135a05b721f15284c69f4066bc9..8592c14cb4432d25beb2d110fc400a26f1661a5e 100644 (file)
@@ -18,7 +18,7 @@ import static org.mockito.Mockito.*;
 import static org.openhab.binding.mielecloud.internal.util.MieleCloudBindingIntegrationTestConstants.*;
 import static org.openhab.binding.mielecloud.internal.util.ReflectionUtil.*;
 
-import java.util.Collections;
+import java.util.Map;
 import java.util.Objects;
 import java.util.Optional;
 
@@ -126,9 +126,8 @@ public class MieleBridgeHandlerTest extends OpenHabOsgiTest {
         bridge = BridgeBuilder
                 .create(MieleCloudBindingConstants.THING_TYPE_BRIDGE,
                         MieleCloudBindingIntegrationTestConstants.BRIDGE_THING_UID)
-                .withConfiguration(
-                        new Configuration(Collections.singletonMap(MieleCloudBindingConstants.CONFIG_PARAM_EMAIL,
-                                MieleCloudBindingIntegrationTestConstants.EMAIL)))
+                .withConfiguration(new Configuration(Map.of(MieleCloudBindingConstants.CONFIG_PARAM_EMAIL,
+                        MieleCloudBindingIntegrationTestConstants.EMAIL)))
                 .withLabel(MIELE_CLOUD_ACCOUNT_LABEL).build();
         assertNotNull(bridge);
 
@@ -484,7 +483,8 @@ public class MieleBridgeHandlerTest extends OpenHabOsgiTest {
     @Test
     public void testNoLanguageIsReturnedWhenTheConfigurationParameterIsEmpty() {
         // given:
-        getHandler().handleConfigurationUpdate(Collections.singletonMap(CONFIG_PARAM_LOCALE, ""));
+        getHandler().handleConfigurationUpdate(
+                Map.of(MieleCloudBindingConstants.CONFIG_PARAM_EMAIL, SERVICE_HANDLE, CONFIG_PARAM_LOCALE, ""));
 
         // when:
         Optional<String> language = getHandler().getLanguage();
@@ -496,7 +496,8 @@ public class MieleBridgeHandlerTest extends OpenHabOsgiTest {
     @Test
     public void testNoLanguageIsReturnedWhenTheConfigurationParameterIsNotAValidTwoLetterLanguageCode() {
         // given:
-        getHandler().handleConfigurationUpdate(Collections.singletonMap(CONFIG_PARAM_LOCALE, "Deutsch"));
+        getHandler().handleConfigurationUpdate(
+                Map.of(MieleCloudBindingConstants.CONFIG_PARAM_EMAIL, SERVICE_HANDLE, CONFIG_PARAM_LOCALE, "Deutsch"));
 
         // when:
         Optional<String> language = getHandler().getLanguage();
@@ -508,7 +509,8 @@ public class MieleBridgeHandlerTest extends OpenHabOsgiTest {
     @Test
     public void testAValidTwoLetterLanguageCodeIsReturnedWhenTheConfigurationParameterIsSetToTheTwoLetterLanguageCode() {
         // given:
-        getHandler().handleConfigurationUpdate(Collections.singletonMap(CONFIG_PARAM_LOCALE, "DE"));
+        getHandler().handleConfigurationUpdate(
+                Map.of(MieleCloudBindingConstants.CONFIG_PARAM_EMAIL, SERVICE_HANDLE, CONFIG_PARAM_LOCALE, "DE"));
 
         // when:
         String language = getHandler().getLanguage().get();