[hdpowerview] Secondary shade position was inverted (#11552)

* [hdpowerview] get secondary shade position value was inverted

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [hdpowerview] remove testing Jar from PR

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>

diff --git a/bundles/org.openhab.binding.hdpowerview/src/main/java/org/openhab/binding/hdpowerview/internal/api/ShadePosition.java b/bundles/org.openhab.binding.hdpowerview/src/main/java/org/openhab/binding/hdpowerview/internal/api/ShadePosition.java
index a61d04c3732dbed8293d978f7cfd18afbdab1dc5..c7e5f0477d96ee2fbe11c80d42ba5f8a4ad2e099 100644 (file)
--- a/bundles/org.openhab.binding.hdpowerview/src/main/java/org/openhab/binding/hdpowerview/internal/api/ShadePosition.java
+++ b/bundles/org.openhab.binding.hdpowerview/src/main/java/org/openhab/binding/hdpowerview/internal/api/ShadePosition.java
@@ -236,7 +236,7 @@ public class ShadePosition {
                  * Uses a coordinate system that is NOT inverted in relation to OpenHAB
                  */
                 if (posKind2.intValue() != 3) {
-                    return new PercentType(100 - (int) Math.round(position2.doubleValue() / MAX_SHADE * 100));
+                    return new PercentType((int) Math.round(position2.doubleValue() / MAX_SHADE * 100));
                 }
             default:
                 return UnDefType.UNDEF;

diff --git a/bundles/org.openhab.binding.hdpowerview/src/test/java/org/openhab/binding/hdpowerview/HDPowerViewJUnitTests.java b/bundles/org.openhab.binding.hdpowerview/src/test/java/org/openhab/binding/hdpowerview/HDPowerViewJUnitTests.java
index 46240065fbaf712c16fcba769af2e49db07eb936..14eb6c0aaa595c977e372df25224ac9ef31631dc 100644 (file)
--- a/bundles/org.openhab.binding.hdpowerview/src/test/java/org/openhab/binding/hdpowerview/HDPowerViewJUnitTests.java
+++ b/bundles/org.openhab.binding.hdpowerview/src/test/java/org/openhab/binding/hdpowerview/HDPowerViewJUnitTests.java
@@ -351,7 +351,7 @@ public class HDPowerViewJUnitTests {
 
             pos = shadePos.getState(SECONDARY_ACTUATOR, ZERO_IS_OPEN);
             assertEquals(PercentType.class, pos.getClass());
-            assertEquals(65, ((PercentType) pos).intValue());
+            assertEquals(35, ((PercentType) pos).intValue());
 
             pos = shadePos.getState(PRIMARY_ACTUATOR, VANE_COORDS);
             assertEquals(UnDefType.class, pos.getClass());