]> git.basschouten.com Git - openhab-addons.git/commitdiff
[dwdunwetter] Handle possible XXE injection (#15466)
authorHolger Friedrich <holgerfriedrich@users.noreply.github.com>
Tue, 29 Aug 2023 16:50:13 +0000 (18:50 +0200)
committerGitHub <noreply@github.com>
Tue, 29 Aug 2023 16:50:13 +0000 (18:50 +0200)
XMLInputFactory: Disable properties IS_SUPPORTING_EXTERNAL_ENTITIES and
SUPPORT_DTD which allow injecting external entities.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
bundles/org.openhab.binding.dwdunwetter/src/main/java/org/openhab/binding/dwdunwetter/internal/dto/DwdWarningsData.java

index 41ae77917f9a8cb6c8ea55bae0e5417d1387db9c..80a39e606675b3e823073ccfa09a87443f7a232c 100644 (file)
@@ -119,6 +119,8 @@ public class DwdWarningsData {
 
         try {
             XMLInputFactory inputFactory = XMLInputFactory.newInstance();
+            inputFactory.setProperty(XMLInputFactory.IS_SUPPORTING_EXTERNAL_ENTITIES, false);
+            inputFactory.setProperty(XMLInputFactory.SUPPORT_DTD, false);
             XMLStreamReader reader = inputFactory.createXMLStreamReader(new StringReader(rawData));
             XMLEventReader eventReader = inputFactory.createXMLEventReader(reader);
             DwdWarningData gemeindeData = new DwdWarningData();