From: Cody Cutrer <cody@cutrer.us>
Date: Fri, 27 Jan 2023 23:39:19 +0000 (-0700)
Subject: [homekit] fix restarted on network interface change (#14226)
X-Git-Url: https://git.basschouten.com/?a=commitdiff_plain;h=0312e687ba043e949df06f266dd969ac7c8216e1;p=openhab-addons.git

[homekit] fix restarted on network interface change (#14226)

a regression caused during the final changes of #13877

Signed-off-by: Cody Cutrer <cody@cutrer.us>
---

diff --git a/bundles/org.openhab.io.homekit/src/main/java/org/openhab/io/homekit/internal/HomekitImpl.java b/bundles/org.openhab.io.homekit/src/main/java/org/openhab/io/homekit/internal/HomekitImpl.java
index dfe91464a6..3226e770fd 100644
--- a/bundles/org.openhab.io.homekit/src/main/java/org/openhab/io/homekit/internal/HomekitImpl.java
+++ b/bundles/org.openhab.io.homekit/src/main/java/org/openhab/io/homekit/internal/HomekitImpl.java
@@ -87,7 +87,7 @@ public class HomekitImpl implements Homekit, NetworkAddressChangeListener, Ready
     private final List<HomekitServer> homekitServers = new ArrayList<>();
     private final List<HomekitRoot> bridges = new ArrayList<>();
     private MDNSClient mdnsClient;
-    private int currentStartLevel = 0;
+    private boolean started = false;
 
     private final List<HomekitChangeListener> changeListeners = new ArrayList<>();
 
@@ -170,7 +170,7 @@ public class HomekitImpl implements Homekit, NetworkAddressChangeListener, Ready
                     clearStorage(i);
                 }
                 stopHomekitServer();
-                if (currentStartLevel >= StartLevelService.STARTLEVEL_STATES) {
+                if (started) {
                     startHomekitServer();
                 }
             } else {
@@ -201,6 +201,7 @@ public class HomekitImpl implements Homekit, NetworkAddressChangeListener, Ready
     @Override
     public synchronized void onReadyMarkerAdded(ReadyMarker readyMarker) {
         try {
+            started = true;
             startHomekitServer();
         } catch (IOException | InvalidAlgorithmParameterException e) {
             logger.warn("could not initialize HomeKit bridge: {}", e.getMessage());
@@ -209,6 +210,7 @@ public class HomekitImpl implements Homekit, NetworkAddressChangeListener, Ready
 
     @Override
     public synchronized void onReadyMarkerRemoved(ReadyMarker readyMarker) {
+        started = false;
         stopHomekitServer();
     }
 
@@ -411,7 +413,7 @@ public class HomekitImpl implements Homekit, NetworkAddressChangeListener, Ready
     @Override
     public synchronized void onChanged(final List<CidrAddress> added, final List<CidrAddress> removed) {
         logger.trace("HomeKit bridge reacting on network interface changes.");
-        if (currentStartLevel < StartLevelService.STARTLEVEL_STATES) {
+        if (!started) {
             return;
         }
         removed.forEach(i -> {