From: Andrew Fiddian-Green <software@whitebear.ch>
Date: Mon, 5 Feb 2024 18:53:38 +0000 (+0000)
Subject: [growatt] change battery display channel unit to volt (#16377)
X-Git-Url: https://git.basschouten.com/?a=commitdiff_plain;h=23b94d78d62a2c99f351756ef98158c11e027857;p=openhab-addons.git

[growatt] change battery display channel unit to volt (#16377)

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
---

diff --git a/bundles/org.openhab.binding.growatt/src/main/java/org/openhab/binding/growatt/internal/GrowattChannels.java b/bundles/org.openhab.binding.growatt/src/main/java/org/openhab/binding/growatt/internal/GrowattChannels.java
index 503fd1ccd4..a03519e005 100644
--- a/bundles/org.openhab.binding.growatt/src/main/java/org/openhab/binding/growatt/internal/GrowattChannels.java
+++ b/bundles/org.openhab.binding.growatt/src/main/java/org/openhab/binding/growatt/internal/GrowattChannels.java
@@ -164,7 +164,7 @@ public class GrowattChannels {
             new AbstractMap.SimpleEntry<String, UoM>("battery-type", new UoM(Units.ONE, 1)),
             new AbstractMap.SimpleEntry<String, UoM>("battery-voltage", new UoM(Units.VOLT, 10)),
             new AbstractMap.SimpleEntry<String, UoM>("battery-temperature", new UoM(SIUnits.CELSIUS, 10)),
-            new AbstractMap.SimpleEntry<String, UoM>("battery-display", new UoM(Units.ONE, 10)),
+            new AbstractMap.SimpleEntry<String, UoM>("battery-display", new UoM(Units.VOLT, 10)),
             new AbstractMap.SimpleEntry<String, UoM>("battery-soc", new UoM(Units.PERCENT, 1)),
 
             // fault codes
diff --git a/bundles/org.openhab.binding.growatt/src/main/resources/OH-INF/i18n/growatt.properties b/bundles/org.openhab.binding.growatt/src/main/resources/OH-INF/i18n/growatt.properties
index 6c11e74471..20aea41917 100644
--- a/bundles/org.openhab.binding.growatt/src/main/resources/OH-INF/i18n/growatt.properties
+++ b/bundles/org.openhab.binding.growatt/src/main/resources/OH-INF/i18n/growatt.properties
@@ -10,7 +10,7 @@ thing-type.growatt.bridge.description = Bridge Thing for Growatt Binding
 thing-type.growatt.inverter.label = Growatt Inverter
 thing-type.growatt.inverter.description = Inverter Thing for Growatt Binding
 thing-type.growatt.inverter.channel.battery-display.label = Battery Display
-thing-type.growatt.inverter.channel.battery-display.description = Battery display code.
+thing-type.growatt.inverter.channel.battery-display.description = Battery display voltage.
 thing-type.growatt.inverter.channel.battery-soc.label = Battery Charge
 thing-type.growatt.inverter.channel.battery-soc.description = Battery state of charge.
 thing-type.growatt.inverter.channel.battery-temperature.label = Battery Temperature
diff --git a/bundles/org.openhab.binding.growatt/src/main/resources/OH-INF/thing/thing-types.xml b/bundles/org.openhab.binding.growatt/src/main/resources/OH-INF/thing/thing-types.xml
index a736a13e8f..0fe5bccadf 100644
--- a/bundles/org.openhab.binding.growatt/src/main/resources/OH-INF/thing/thing-types.xml
+++ b/bundles/org.openhab.binding.growatt/src/main/resources/OH-INF/thing/thing-types.xml
@@ -364,9 +364,9 @@
 				<label>Battery Voltage</label>
 				<description>Battery voltage.</description>
 			</channel>
-			<channel id="battery-display" typeId="advanced-status-code">
+			<channel id="battery-display" typeId="advanced-electric-voltage">
 				<label>Battery Display</label>
-				<description>Battery display code.</description>
+				<description>Battery display voltage.</description>
 			</channel>
 			<channel id="battery-soc" typeId="advanced-percent">
 				<label>Battery Charge</label>