From: Andrew Fiddian-Green <software@whitebear.ch>
Date: Sun, 18 Oct 2020 18:26:50 +0000 (+0100)
Subject: [hdpowerview] discovery could wrongly return a ThingUID based on a hub's Ipv6 address... 
X-Git-Url: https://git.basschouten.com/?a=commitdiff_plain;h=5fe7cc5810bcebded339300c47a38bcb68e46ce0;p=openhab-addons.git

[hdpowerview] discovery could wrongly return a ThingUID based on a hub's Ipv6 address instead of its Ipv4 address (#8778)

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
---

diff --git a/bundles/org.openhab.binding.hdpowerview/src/main/java/org/openhab/binding/hdpowerview/internal/discovery/HDPowerViewHubDiscoveryParticipant.java b/bundles/org.openhab.binding.hdpowerview/src/main/java/org/openhab/binding/hdpowerview/internal/discovery/HDPowerViewHubDiscoveryParticipant.java
index eb05783270..a9b4ba7e81 100644
--- a/bundles/org.openhab.binding.hdpowerview/src/main/java/org/openhab/binding/hdpowerview/internal/discovery/HDPowerViewHubDiscoveryParticipant.java
+++ b/bundles/org.openhab.binding.hdpowerview/src/main/java/org/openhab/binding/hdpowerview/internal/discovery/HDPowerViewHubDiscoveryParticipant.java
@@ -75,7 +75,9 @@ public class HDPowerViewHubDiscoveryParticipant implements MDNSDiscoveryParticip
     @Override
     public @Nullable ThingUID getThingUID(ServiceInfo service) {
         for (String host : service.getHostAddresses()) {
-            return new ThingUID(THING_TYPE_HUB, host.replace('.', '_'));
+            if (VALID_IP_V4_ADDRESS.matcher(host).matches()) {
+                return new ThingUID(THING_TYPE_HUB, host.replace('.', '_'));
+            }
         }
         return null;
     }