From: Bo Biene <openhab.github@biene.eu>
Date: Sun, 2 Jan 2022 15:51:51 +0000 (+0100)
Subject: [wolfsmartset] Fix NullPointerException when updating values (#11931)
X-Git-Url: https://git.basschouten.com/?a=commitdiff_plain;h=6deb3f56da3a6f679b0b6a7021999bcf062467e6;p=openhab-addons.git

[wolfsmartset] Fix NullPointerException when updating values (#11931)

* fix bug #11930 NullPointerException

Signed-off-by: Bo Biene <openhab.github@biene.eu>
---

diff --git a/bundles/org.openhab.binding.wolfsmartset/src/main/java/org/openhab/binding/wolfsmartset/internal/dto/GetParameterValuesDTO.java b/bundles/org.openhab.binding.wolfsmartset/src/main/java/org/openhab/binding/wolfsmartset/internal/dto/GetParameterValuesDTO.java
index bab0e0a746..60305d5816 100644
--- a/bundles/org.openhab.binding.wolfsmartset/src/main/java/org/openhab/binding/wolfsmartset/internal/dto/GetParameterValuesDTO.java
+++ b/bundles/org.openhab.binding.wolfsmartset/src/main/java/org/openhab/binding/wolfsmartset/internal/dto/GetParameterValuesDTO.java
@@ -53,8 +53,8 @@ public class GetParameterValuesDTO {
         this.values = values;
     }
 
-    public Boolean getIsNewJobCreated() {
-        return isNewJobCreated;
+    public boolean getIsNewJobCreated() {
+        return isNewJobCreated != null ? isNewJobCreated : false;
     }
 
     public void setIsNewJobCreated(Boolean isNewJobCreated) {
diff --git a/bundles/org.openhab.binding.wolfsmartset/src/main/java/org/openhab/binding/wolfsmartset/internal/handler/WolfSmartsetUnitThingHandler.java b/bundles/org.openhab.binding.wolfsmartset/src/main/java/org/openhab/binding/wolfsmartset/internal/handler/WolfSmartsetUnitThingHandler.java
index 47332440f6..8a6d69f96c 100644
--- a/bundles/org.openhab.binding.wolfsmartset/src/main/java/org/openhab/binding/wolfsmartset/internal/handler/WolfSmartsetUnitThingHandler.java
+++ b/bundles/org.openhab.binding.wolfsmartset/src/main/java/org/openhab/binding/wolfsmartset/internal/handler/WolfSmartsetUnitThingHandler.java
@@ -184,7 +184,7 @@ public class WolfSmartsetUnitThingHandler extends BaseThingHandler {
      */
     public void updateValues(@Nullable GetParameterValuesDTO values) {
         var thingId = thing.getUID();
-        if (values != null && values.getValues() != null && values.getValues().size() > 0) {
+        if (values != null && values.getValues() != null && !values.getValues().isEmpty()) {
             if (!values.getIsNewJobCreated()) {
                 lastRefreshTime = Instant.now();
             }