From: Florian Hotze <florianh_dev@icloud.com>
Date: Tue, 6 Dec 2022 12:15:47 +0000 (+0100)
Subject: [jsscripting] Fix "Error removing engine" context already closed (#13855)
X-Git-Url: https://git.basschouten.com/?a=commitdiff_plain;h=a9d4244fd81e8016c78eee5a7676bfd0c60b75a1;p=openhab-addons.git

[jsscripting] Fix "Error removing engine" context already closed (#13855)

In recent PR #13824, I added closing the context when the engine is closed, but core seems to have problems with that.

It logs: "[ERROR] [ipt.internal.ScriptEngineManagerImpl] - Error removing ScriptEngine
java.lang.IllegalStateException: The Context is already closed."

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
---

diff --git a/bundles/org.openhab.automation.jsscripting/src/main/java/org/openhab/automation/jsscripting/internal/OpenhabGraalJSScriptEngine.java b/bundles/org.openhab.automation.jsscripting/src/main/java/org/openhab/automation/jsscripting/internal/OpenhabGraalJSScriptEngine.java
index d870f59832..92dfd5b737 100644
--- a/bundles/org.openhab.automation.jsscripting/src/main/java/org/openhab/automation/jsscripting/internal/OpenhabGraalJSScriptEngine.java
+++ b/bundles/org.openhab.automation.jsscripting/src/main/java/org/openhab/automation/jsscripting/internal/OpenhabGraalJSScriptEngine.java
@@ -237,7 +237,6 @@ public class OpenhabGraalJSScriptEngine
     @Override
     public void close() {
         jsRuntimeFeatures.close();
-        delegate.close();
     }
 
     /**