From: mlobstein <michael.lobstein@gmail.com>
Date: Fri, 1 Sep 2023 21:16:16 +0000 (-0500)
Subject: Fix Reconnect error race condition (#15536)
X-Git-Url: https://git.basschouten.com/?a=commitdiff_plain;h=b9a0e6fa14e3834ec79a1f6b3d78161a65e70122;p=openhab-addons.git

Fix Reconnect error race condition (#15536)

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
---

diff --git a/bundles/org.openhab.binding.monopriceaudio/src/main/java/org/openhab/binding/monopriceaudio/internal/handler/MonopriceAudioHandler.java b/bundles/org.openhab.binding.monopriceaudio/src/main/java/org/openhab/binding/monopriceaudio/internal/handler/MonopriceAudioHandler.java
index 2c3a2024a9..d54c259086 100644
--- a/bundles/org.openhab.binding.monopriceaudio/src/main/java/org/openhab/binding/monopriceaudio/internal/handler/MonopriceAudioHandler.java
+++ b/bundles/org.openhab.binding.monopriceaudio/src/main/java/org/openhab/binding/monopriceaudio/internal/handler/MonopriceAudioHandler.java
@@ -482,7 +482,6 @@ public class MonopriceAudioHandler extends BaseThingHandler implements Monoprice
                     String error = null;
 
                     if (openConnection()) {
-                        long prevUpdateTime = lastPollingUpdate;
                         // poll all zones on the amplifier to get current state
                         amp.getZoneIds().stream().limit(numZones).forEach((streamZoneId) -> {
                             try {
@@ -505,11 +504,6 @@ public class MonopriceAudioHandler extends BaseThingHandler implements Monoprice
                                 logger.debug("Error sending Xantech periodic update commands: {}", e.getMessage());
                             }
                         }
-
-                        // prevUpdateTime should have changed if a zone update was received
-                        if (lastPollingUpdate == prevUpdateTime) {
-                            error = "@text/offline.communication-error-polling";
-                        }
                     } else {
                         error = "@text/offline.communication-error-reconnection";
                     }
@@ -518,7 +512,6 @@ public class MonopriceAudioHandler extends BaseThingHandler implements Monoprice
                         updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.COMMUNICATION_ERROR, error);
                     } else {
                         updateStatus(ThingStatus.ONLINE);
-                        lastPollingUpdate = System.currentTimeMillis();
                     }
                 }
             }