From: Wouter Born <github@maindrain.net>
Date: Sun, 13 Mar 2022 19:26:32 +0000 (+0100)
Subject: [mail] Fix unstable MailBuilderTest (#12471)
X-Git-Url: https://git.basschouten.com/?a=commitdiff_plain;h=cb1c1e586e32d831071592509dbb0ef77c8c6021;p=openhab-addons.git

[mail] Fix unstable MailBuilderTest (#12471)

When a URL attachment is used a check is done if an InputStream to the URL can be opened to see if it is valid.
Because the openHAB website was used the test would fail when the website has issues:

```
[ERROR]  org.openhab.binding.mail.MailBuilderTest.withURLAttachmentReturnsMultiPartEmail  Time elapsed: 10.391 s  <<< ERROR!
org.apache.commons.mail.EmailException: Invalid URL set:http://www.openhab.org
	at org.openhab.binding.mail.MailBuilderTest.withURLAttachmentReturnsMultiPartEmail(MailBuilderTest.java:77)
Caused by: java.io.IOException: Server returned HTTP response code: 520 for URL: http://www.openhab.org
	at org.openhab.binding.mail.MailBuilderTest.withURLAttachmentReturnsMultiPartEmail(MailBuilderTest.java:77)
```

It will now use a file URL instead so it is no longer depends on a website.

Signed-off-by: Wouter Born <github@maindrain.net>
---

diff --git a/bundles/org.openhab.binding.mail/src/test/java/org/openhab/binding/mail/MailBuilderTest.java b/bundles/org.openhab.binding.mail/src/test/java/org/openhab/binding/mail/MailBuilderTest.java
index 1f5d31d061..7d7dfda4d9 100644
--- a/bundles/org.openhab.binding.mail/src/test/java/org/openhab/binding/mail/MailBuilderTest.java
+++ b/bundles/org.openhab.binding.mail/src/test/java/org/openhab/binding/mail/MailBuilderTest.java
@@ -18,6 +18,7 @@ import static org.junit.jupiter.api.Assertions.*;
 
 import java.io.IOException;
 import java.net.MalformedURLException;
+import java.nio.file.Path;
 import java.util.Map;
 
 import javax.mail.MessagingException;
@@ -74,7 +75,8 @@ public class MailBuilderTest {
     public void withURLAttachmentReturnsMultiPartEmail()
             throws AddressException, EmailException, MalformedURLException {
         MailBuilder builder = new MailBuilder(TEST_EMAIL);
-        Email mail = builder.withText("boo").withURLAttachment("http://www.openhab.org").build();
+        String url = Path.of("src/test/resources/attachment.txt").toUri().toURL().toString();
+        Email mail = builder.withText("boo").withURLAttachment(url).build();
         assertThat(mail, instanceOf(MultiPartEmail.class));
     }
 
diff --git a/bundles/org.openhab.binding.mail/src/test/resources/attachment.txt b/bundles/org.openhab.binding.mail/src/test/resources/attachment.txt
new file mode 100644
index 0000000000..dafe6b1165
--- /dev/null
+++ b/bundles/org.openhab.binding.mail/src/test/resources/attachment.txt
@@ -0,0 +1 @@
+Lorem ipsum dolor sit amet, ut sed dolores repudiandae, no sit inani euripidis.