From: LukasA83 <58861945+LukasA83@users.noreply.github.com>
Date: Tue, 1 Dec 2020 01:30:00 +0000 (+0100)
Subject: [deconz] Fix Thermostat setting target temperature (#9189)
X-Git-Url: https://git.basschouten.com/?a=commitdiff_plain;h=d3b9bd592b4da3e1f636abf33aed721434c55234;p=openhab-addons.git

[deconz] Fix Thermostat setting target temperature (#9189)

Improve logging on sending commands by checking http response status
code


Signed-off-by: Lukas Agethen <lukas83@gmx.de>
---

diff --git a/bundles/org.openhab.binding.deconz/src/main/java/org/openhab/binding/deconz/internal/handler/DeconzBaseThingHandler.java b/bundles/org.openhab.binding.deconz/src/main/java/org/openhab/binding/deconz/internal/handler/DeconzBaseThingHandler.java
index 9676e07e28..6e310ea8d3 100644
--- a/bundles/org.openhab.binding.deconz/src/main/java/org/openhab/binding/deconz/internal/handler/DeconzBaseThingHandler.java
+++ b/bundles/org.openhab.binding.deconz/src/main/java/org/openhab/binding/deconz/internal/handler/DeconzBaseThingHandler.java
@@ -194,9 +194,14 @@ public abstract class DeconzBaseThingHandler<T extends DeconzBaseMessage> extend
             if (acceptProcessing != null) {
                 acceptProcessing.run();
             }
-            logger.trace("Result code={}, body={}", v.getResponseCode(), v.getBody());
+            if (v.getResponseCode() != java.net.HttpURLConnection.HTTP_OK) {
+                logger.warn("Sending command {} to channel {} failed: {} - {}", originalCommand, channelUID,
+                        v.getResponseCode(), v.getBody());
+            } else {
+                logger.trace("Result code={}, body={}", v.getResponseCode(), v.getBody());
+            }
         }).exceptionally(e -> {
-            logger.debug("Sending command {} to channel {} failed: {} - {}", originalCommand, channelUID, e.getClass(),
+            logger.warn("Sending command {} to channel {} failed: {} - {}", originalCommand, channelUID, e.getClass(),
                     e.getMessage());
             return null;
         });
diff --git a/bundles/org.openhab.binding.deconz/src/main/java/org/openhab/binding/deconz/internal/types/ResourceType.java b/bundles/org.openhab.binding.deconz/src/main/java/org/openhab/binding/deconz/internal/types/ResourceType.java
index 6a33ad00a4..02ddf78c49 100644
--- a/bundles/org.openhab.binding.deconz/src/main/java/org/openhab/binding/deconz/internal/types/ResourceType.java
+++ b/bundles/org.openhab.binding.deconz/src/main/java/org/openhab/binding/deconz/internal/types/ResourceType.java
@@ -29,7 +29,7 @@ import org.slf4j.LoggerFactory;
 public enum ResourceType {
     GROUPS("groups", "action"),
     LIGHTS("lights", "state"),
-    SENSORS("sensors", ""),
+    SENSORS("sensors", "config"),
     UNKNOWN("", "");
 
     private static final Map<String, ResourceType> MAPPING = Arrays.stream(ResourceType.values())