From: Matthew Skinner Date: Mon, 20 Dec 2021 17:59:06 +0000 (+1100) Subject: Fix Global OFF not turning lights/segments off. (#11806) X-Git-Url: https://git.basschouten.com/?a=commitdiff_plain;h=dd951cee02a1e5922d00c659e9fea0693bb90be6;p=openhab-addons.git Fix Global OFF not turning lights/segments off. (#11806) Signed-off-by: Matthew Skinner --- diff --git a/bundles/org.openhab.binding.wled/src/main/java/org/openhab/binding/wled/internal/api/WledApiV084.java b/bundles/org.openhab.binding.wled/src/main/java/org/openhab/binding/wled/internal/api/WledApiV084.java index 4d3245af4c..270940544d 100644 --- a/bundles/org.openhab.binding.wled/src/main/java/org/openhab/binding/wled/internal/api/WledApiV084.java +++ b/bundles/org.openhab.binding.wled/src/main/java/org/openhab/binding/wled/internal/api/WledApiV084.java @@ -284,8 +284,8 @@ public class WledApiV084 implements WledApi { handler.update(CHANNEL_THIRD_WHITE, WLedHelper .parseWhitePercent(state.stateResponse.seg[handler.config.segmentIndex].col[2].toString())); } - - if (!state.stateResponse.seg[handler.config.segmentIndex].on) { + // Global OFF or Segment OFF needs to be treated as OFF + if (!state.stateResponse.seg[handler.config.segmentIndex].on || !state.stateResponse.on) { handler.update(CHANNEL_MASTER_CONTROLS, OnOffType.OFF); handler.update(CHANNEL_SEGMENT_BRIGHTNESS, OnOffType.OFF); } else {