[gardena] Improve GardenaSmartImpl initialization order (#14722)
If an exception occurs during httpClient.start(), webSocketClient
remained null, which led to another (then unhandled) exception being thrown
by dispose(), called in the exception handler.
With the new initialization order it's ensured webSocketClient is not
null at dispose() time, thus allowing proper propagation of the
exception thrown at HTTP startup.
Signed-off-by: Danny Baumann <dannybaumann@web.de>
David Pace [Thu, 30 Mar 2023 16:31:54 +0000 (18:31 +0200)]
[boschshc] Code Enhancements (#14667)
* [boschshc] Code Enhancements
This commit fixes several compiler warnings as well as several
Checkstyle, FindBugs, PMD and Sonar issues.
* instantiate loggers consistently
* add missing logger calls
* add chained exceptions to logger calls
* provide central Gson instance that does not serialize or deserialize
loggers
* avoid catching NullPointerExceptions
* extract methods where cyclomatic complexity was too high
* remove unnecessary null check in combination with instanceof
* rename local variables that shadow fields
* add missing @NonNull and @Nullable annotations
Zhivka Dimova [Wed, 29 Mar 2023 21:00:31 +0000 (23:00 +0200)]
[enocean] Add support for EEP in group A5_09 (#13793)
* [enocean] Support for gas sensors from A5_09 group
Implementing support for gas sensors with EEP A5_09_02, 04, 05, 08, 09,
0C, 0D, adding new changels - CO, CO2, VOC, VOCId, TVOC and regenerate
I18N properties file
https://github.com/openhab/openhab-addons/pull/12238 was merged after
JSON Schema Light was implemented, and changed some assumptions.
this commit adjusts to the changed interface
openhab-bot [Mon, 27 Mar 2023 06:33:34 +0000 (08:33 +0200)]
New Crowdin updates (#14689)
* New translations deconz.properties (German)
* New translations netatmo.properties (Italian)
* New translations avmfritz.properties (German)
* New translations openwebnet.properties (Italian)
* [mqtt.homeassistant] implement JSON schema lights
* [mqtt.homeassistant] use enum for current state of color mode
* [mqtt.homeassistant] use implicit lambdas
* [mqtt.homeassistant] remove string constants in favor of an enum
* [mqtt.homeassistant] allow sending ON and brightness commands through bare
* [mqtt.homeassistant] turn down debug logging
Sven Strohschein [Sun, 26 Mar 2023 15:34:35 +0000 (17:34 +0200)]
[netatmo] Extend webhook support for doorbell and presence camera (#14252)
* [netatmo] Web hook extension for camera events
- Unused camera-event trigger channel removed
- README updated to the real supported channels (compared with channels.xml and code)
- Camera capabilities are now triggering the home-event trigger channel
- New home-event trigger channel introduced at camera level
- New sub-event channels introduced for the presence camera which is updated by web hook events.
- Language file updated
- README updated
- typos fixed
- security-event trigger channel added for the Welcome camera
- Handling of sub-event groups fixed to work with doorbell and presence cameras.
---------
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com> Signed-off-by: Sven Strohschein <novanic@gmx.de>
M Valla [Sun, 26 Mar 2023 10:19:31 +0000 (12:19 +0200)]
[openwebnet] Reset zones' alarm state channel when system is armed (#14566)
* [openwebnet] reset zones alarm channel when system is armed and added NONE state
* [openwebnet] added Technical reset alarm. Changes after 1st review
Gerd Zanker [Fri, 24 Mar 2023 23:26:24 +0000 (00:26 +0100)]
[boschshc] Bridge and Device Discovery (#14197)
* #14195 Bridge and Device Discovery
Bridge discovery is implemented via mDNS, local IP addresses are checked.
If a GET returns the public SHC information,
then this shcIpAddress is reported as a discovered bridge.
Devices are always discovered after successful pairing, but a manual scan is also possible.
Björn Lange [Fri, 24 Mar 2023 22:15:28 +0000 (23:15 +0100)]
[mielecloud] Add channels energy and water consumption (#14456)
* Add POJOs for ecoFeedback from Miele REST API
* DeviceState offers water and energy consumption
* Convert Quantity to State for channel population
* Add eco feedback channels to devices
* Fix item types and categories
* Add update instructions for eco feedback channels
Signed-off-by: Björn Lange <bjoern.lange@itemis.de>
Cody Cutrer [Wed, 22 Mar 2023 12:58:12 +0000 (06:58 -0600)]
[homekit] Unify all enum handling (#14036)
* [homekit] unify all enum handling
regardless of if it's a required or optional characteristic,
or even "boolean" enums
then allow number or switch items to be linked with enums
then update the docs listing the numeric value for enums
as part of this, global configuration of thermostat enum values
is no longer supported; you must use metadata.
in particular, for GarageDoorOpener, the global settings didn't
even actually work, so they should work now.
Fixes #13595
* [homekit] default-invert boolean items for garage door states
this was previously handled explicitly by the switch statement.
so need to set the inverted flag now that we're building a
mapping instead
* [homekit] document that CurrentDoorState can be linked to a Contact item
* [homekit] improve docs on invert param to createMapping
also fix a new helper method not properly passing through the inverted
param
Holger Friedrich [Fri, 17 Mar 2023 11:50:13 +0000 (12:50 +0100)]
[knx] Refactoring of KnxCoreTypeMapper and UOM Support (#14534)
* [knx] Refactoring, add basic support for UOM
Preparation for refactoring KnxCoreTypeMapper.
Carryover from smarthomej/addons#107.
Merge UOM implementations.
* [knx] Adapt tests
DPT strings for QuantityType now strip off a tailing .0 when decimals
are converted.
* [knx] Refactoring
Use pattern matching with instanceof operator (new Java17 feature).
* [knx] Refactoring, performance improvements
Introduce KNXChannel class.
Carryover from smarthomej/addons#114.
* [knx] Add warning for incompatible DPT type
Configuring incompatible DPT/channel combinations (e.g. DPT 1.005 (alarm) on Contact channels
or DPT 1.019 (windows/door) on Switch channels) is not allowed but was silently ignored.
This PR adds a warning in case incompatible configurations are detected.
Carryover from smarthomej/addons#203.
* [knx] Add full support for UoM
Replace UoM handling with the implementation from smarthome/j.
Carryover from smarthomej/addons#206.
* [knx] Refactor KNXCoreTypeMapper, add RGBW and xyY
Carryover from smarthomej/addons#208.
* [knx] Fix RGB conversion
Carryover from smarthomej/addons#219.
* [knx] Remove workarounds obsoleted by Calimero 2.5
Carryover from smarthomej/addons#226.
* [knx] Add parameter for disabling incoming UoM
Carryover from smarthomej/addons#230.
* [knx] Fix fallback to DecimalType in number conversion
Carryover from smarthomej/addons#279.
* [knx] Fix DPT 251.600 decoding
Carryover from smarthomej/addons#349.
* [knx] Fix UoM handling for special types
* [knx] Add test for KNXChannelFactory
* [knx] Update CODEOWNERS for knx
* [knx] Default conversion for DPT 5.001 and 6.001
* [knx] Fix write blocked forever after read from bus
Carryover from smarthomej/addons#299 and smarthomej/addons#330.
* [knx] Use new class ColorUtil from core for HSB conversion
Also-by: Jan N. Klug <github@klug.nrw> Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
openhab-bot [Mon, 13 Mar 2023 21:22:53 +0000 (22:22 +0100)]
New Crowdin updates (#14597)
* New translations openweathermap.properties (Italian)
* New translations netatmo.properties (Italian)
* New translations qolsysiq.properties (Italian)
* New translations astro.properties (German)
* New translations astro.properties (Italian)
* New translations danfossairunit.properties (Danish)