From 4409cf63c9a3aa6837d78bf811287b70caf636b8 Mon Sep 17 00:00:00 2001 From: robnielsen Date: Sat, 19 Dec 2020 13:18:10 -0600 Subject: [PATCH] only log stack traces to openhab.log if debug is enabled (#9427) Signed-off-by: Rob Nielsen --- .../netatmo/internal/handler/NetatmoBridgeHandler.java | 6 +++++- .../org/openhab/io/openhabcloud/internal/CloudClient.java | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/bundles/org.openhab.binding.netatmo/src/main/java/org/openhab/binding/netatmo/internal/handler/NetatmoBridgeHandler.java b/bundles/org.openhab.binding.netatmo/src/main/java/org/openhab/binding/netatmo/internal/handler/NetatmoBridgeHandler.java index 1cdfc31efe..b86d18ddd3 100644 --- a/bundles/org.openhab.binding.netatmo/src/main/java/org/openhab/binding/netatmo/internal/handler/NetatmoBridgeHandler.java +++ b/bundles/org.openhab.binding.netatmo/src/main/java/org/openhab/binding/netatmo/internal/handler/NetatmoBridgeHandler.java @@ -173,7 +173,11 @@ public class NetatmoBridgeHandler extends BaseBridgeHandler { "Unable to connect Netatmo API : " + e.getLocalizedMessage()); } } catch (RuntimeException e) { - logger.warn("Unable to connect Netatmo API : {}", e.getMessage(), e); + if (logger.isDebugEnabled()) { + logger.warn("Unable to connect Netatmo API : {}", e.getMessage(), e); + } else { + logger.warn("Unable to connect Netatmo API : {}", e.getMessage()); + } updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.COMMUNICATION_ERROR, "Netatmo Access Failed, will retry in " + configuration.reconnectInterval + " seconds."); } diff --git a/bundles/org.openhab.io.openhabcloud/src/main/java/org/openhab/io/openhabcloud/internal/CloudClient.java b/bundles/org.openhab.io.openhabcloud/src/main/java/org/openhab/io/openhabcloud/internal/CloudClient.java index 742df82358..e4df41b1c1 100644 --- a/bundles/org.openhab.io.openhabcloud/src/main/java/org/openhab/io/openhabcloud/internal/CloudClient.java +++ b/bundles/org.openhab.io.openhabcloud/src/main/java/org/openhab/io/openhabcloud/internal/CloudClient.java @@ -199,7 +199,11 @@ public class CloudClient { }).on(Socket.EVENT_ERROR, new Emitter.Listener() { @Override public void call(Object... args) { - logger.error("Error connecting to the openHAB Cloud instance: {}", args[0]); + if (logger.isDebugEnabled()) { + logger.error("Error connecting to the openHAB Cloud instance: {}", args[0]); + } else { + logger.error("Error connecting to the openHAB Cloud instance"); + } } }).on("request", new Emitter.Listener() { @Override -- 2.47.3