From 7728bbc2323ff03d49292fa9dec45f4f2d1fc755 Mon Sep 17 00:00:00 2001 From: lolodomo Date: Tue, 1 Nov 2022 15:30:29 +0100 Subject: [PATCH] [vigicrues] Fix few code analysis findings (#13639) Signed-off-by: Laurent Garnier --- .../vigicrues/internal/api/ApiHandler.java | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/bundles/org.openhab.binding.vigicrues/src/main/java/org/openhab/binding/vigicrues/internal/api/ApiHandler.java b/bundles/org.openhab.binding.vigicrues/src/main/java/org/openhab/binding/vigicrues/internal/api/ApiHandler.java index f98567aa61..5bd8585e92 100644 --- a/bundles/org.openhab.binding.vigicrues/src/main/java/org/openhab/binding/vigicrues/internal/api/ApiHandler.java +++ b/bundles/org.openhab.binding.vigicrues/src/main/java/org/openhab/binding/vigicrues/internal/api/ApiHandler.java @@ -71,28 +71,28 @@ public class ApiHandler { } public InfoVigiCru getTronconStatus(String tronconId) throws VigiCruesException { - final String BASE_URL = "https://www.vigicrues.gouv.fr/services/1/InfoVigiCru.jsonld/?TypEntVigiCru=8&CdEntVigiCru=%s"; - return execute(String.format(BASE_URL, tronconId), InfoVigiCru.class); + final String baseUrl = "https://www.vigicrues.gouv.fr/services/1/InfoVigiCru.jsonld/?TypEntVigiCru=8&CdEntVigiCru=%s"; + return execute(String.format(baseUrl, tronconId), InfoVigiCru.class); } public TronEntVigiCru getTroncon(String stationId) throws VigiCruesException { - final String BASE_URL = "https://www.vigicrues.gouv.fr/services/1/TronEntVigiCru.jsonld/?TypEntVigiCru=8&CdEntVigiCru=%s"; - return execute(String.format(BASE_URL, stationId), TronEntVigiCru.class); + final String baseUrl = "https://www.vigicrues.gouv.fr/services/1/TronEntVigiCru.jsonld/?TypEntVigiCru=8&CdEntVigiCru=%s"; + return execute(String.format(baseUrl, stationId), TronEntVigiCru.class); } public TerEntVigiCru getTerritoire(String stationId) throws VigiCruesException { - final String BASE_URL = "https://www.vigicrues.gouv.fr/services/1/TerEntVigiCru.jsonld/?TypEntVigiCru=5&CdEntVigiCru=%s"; - return execute(String.format(BASE_URL, stationId), TerEntVigiCru.class); + final String baseUrl = "https://www.vigicrues.gouv.fr/services/1/TerEntVigiCru.jsonld/?TypEntVigiCru=5&CdEntVigiCru=%s"; + return execute(String.format(baseUrl, stationId), TerEntVigiCru.class); } public CdStationHydro getStationDetails(String stationId) throws VigiCruesException { - final String BASE_URL = "https://www.vigicrues.gouv.fr/services/station.json/index.php?CdStationHydro=%s"; - return execute(String.format(BASE_URL, stationId), CdStationHydro.class); + final String baseUrl = "https://www.vigicrues.gouv.fr/services/station.json/index.php?CdStationHydro=%s"; + return execute(String.format(baseUrl, stationId), CdStationHydro.class); } public OpenDatasoftResponse getMeasures(String stationId) throws VigiCruesException { - final String BASE_URL = "https://public.opendatasoft.com/api/records/1.0/search/?dataset=vigicrues&sort=timestamp&q=%s"; - return execute(String.format(BASE_URL, stationId), OpenDatasoftResponse.class); + final String baseUrl = "https://public.opendatasoft.com/api/records/1.0/search/?dataset=vigicrues&sort=timestamp&q=%s"; + return execute(String.format(baseUrl, stationId), OpenDatasoftResponse.class); } public HubEauResponse discoverStations(PointType location, int range) throws VigiCruesException { -- 2.47.3