From 79bf9724fc159894be3a3a4e08347ac387d3eaeb Mon Sep 17 00:00:00 2001 From: lolodomo Date: Wed, 2 Nov 2022 08:16:25 +0100 Subject: [PATCH] [netatmo] eventBuffer in SecurityCapability should not be static (#13636) Also fix few findings by code analysis Signed-off-by: Laurent Garnier --- .../binding/netatmo/internal/deserialization/NAPushType.java | 2 +- .../netatmo/internal/handler/capability/SecurityCapability.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bundles/org.openhab.binding.netatmo/src/main/java/org/openhab/binding/netatmo/internal/deserialization/NAPushType.java b/bundles/org.openhab.binding.netatmo/src/main/java/org/openhab/binding/netatmo/internal/deserialization/NAPushType.java index cac492ec68..8e6ebd7c2c 100644 --- a/bundles/org.openhab.binding.netatmo/src/main/java/org/openhab/binding/netatmo/internal/deserialization/NAPushType.java +++ b/bundles/org.openhab.binding.netatmo/src/main/java/org/openhab/binding/netatmo/internal/deserialization/NAPushType.java @@ -23,7 +23,7 @@ import org.openhab.binding.netatmo.internal.api.data.ModuleType; */ @NonNullByDefault public class NAPushType { - public final static NAPushType UNKNOWN = new NAPushType(ModuleType.UNKNOWN, EventType.UNKNOWN); + public static final NAPushType UNKNOWN = new NAPushType(ModuleType.UNKNOWN, EventType.UNKNOWN); private final ModuleType moduleType; private final EventType event; diff --git a/bundles/org.openhab.binding.netatmo/src/main/java/org/openhab/binding/netatmo/internal/handler/capability/SecurityCapability.java b/bundles/org.openhab.binding.netatmo/src/main/java/org/openhab/binding/netatmo/internal/handler/capability/SecurityCapability.java index d7c3a2469a..164edae775 100644 --- a/bundles/org.openhab.binding.netatmo/src/main/java/org/openhab/binding/netatmo/internal/handler/capability/SecurityCapability.java +++ b/bundles/org.openhab.binding.netatmo/src/main/java/org/openhab/binding/netatmo/internal/handler/capability/SecurityCapability.java @@ -47,7 +47,7 @@ import org.slf4j.LoggerFactory; class SecurityCapability extends RestCapability { private final Logger logger = LoggerFactory.getLogger(SecurityCapability.class); - private static final Map eventBuffer = new HashMap<>(); + private final Map eventBuffer = new HashMap<>(); private @Nullable ZonedDateTime freshestEventTime; SecurityCapability(CommonInterface handler) { -- 2.47.3