From 985f89315df52f4814a27c5b24f8df7ddff5d31e Mon Sep 17 00:00:00 2001 From: Holger Friedrich Date: Tue, 27 Jun 2023 20:22:06 +0200 Subject: [PATCH] [knx] Code cleanup (#15141) * cleanup * [knx] Replace StringBuffer with StringBuilder Signed-off-by: Holger Friedrich --- .../binding/knx/internal/client/DeviceInspector.java | 2 +- .../binding/knx/internal/console/KNXCommandExtension.java | 6 ++---- .../knx/internal/handler/KNXBridgeBaseThingHandler.java | 4 ---- .../binding/knx/internal/i18n/KNXTranslationProvider.java | 2 +- 4 files changed, 4 insertions(+), 10 deletions(-) diff --git a/bundles/org.openhab.binding.knx/src/main/java/org/openhab/binding/knx/internal/client/DeviceInspector.java b/bundles/org.openhab.binding.knx/src/main/java/org/openhab/binding/knx/internal/client/DeviceInspector.java index 4e0f05da6b..61aebab5bc 100644 --- a/bundles/org.openhab.binding.knx/src/main/java/org/openhab/binding/knx/internal/client/DeviceInspector.java +++ b/bundles/org.openhab.binding.knx/src/main/java/org/openhab/binding/knx/internal/client/DeviceInspector.java @@ -228,7 +228,7 @@ public class DeviceInspector { byte[] count = getClient().readDeviceProperties(address, ROUTER_OBJECT, PID.FRIENDLY_NAME, 0, 1, false, OPERATION_TIMEOUT); if ((count != null) && (toUnsigned(count) == 30)) { - StringBuffer buf = new StringBuffer(30); + StringBuilder buf = new StringBuilder(30); for (int i = 1; i <= 30; i++) { Thread.sleep(OPERATION_INTERVAL); // for some reason, reading more than one character per message fails diff --git a/bundles/org.openhab.binding.knx/src/main/java/org/openhab/binding/knx/internal/console/KNXCommandExtension.java b/bundles/org.openhab.binding.knx/src/main/java/org/openhab/binding/knx/internal/console/KNXCommandExtension.java index a365f489ca..7a7f389acd 100644 --- a/bundles/org.openhab.binding.knx/src/main/java/org/openhab/binding/knx/internal/console/KNXCommandExtension.java +++ b/bundles/org.openhab.binding.knx/src/main/java/org/openhab/binding/knx/internal/console/KNXCommandExtension.java @@ -12,7 +12,6 @@ */ package org.openhab.binding.knx.internal.console; -import java.util.Arrays; import java.util.List; import java.util.Map.Entry; @@ -56,7 +55,6 @@ public class KNXCommandExtension extends AbstractConsoleCommandExtension impleme for (KNXBridgeBaseThingHandler bridgeHandler : knxHandlerFactory.getBridges()) { console.println("KNX bridge \"" + bridgeHandler.getThing().getLabel() + "\": group address, type, number of bytes, and number of occurence since last reload of binding:"); - // console.println(handler.getCommandExtensionData().unknownGA().toString()); for (Entry entry : bridgeHandler.getCommandExtensionData().unknownGA().entrySet()) { console.println(entry.getKey() + " " + entry.getValue()); } @@ -68,8 +66,8 @@ public class KNXCommandExtension extends AbstractConsoleCommandExtension impleme @Override public List getUsages() { - return Arrays.asList( - buildCommandUsage(CMD_LIST_UNKNOWN_GA, "list group addresses which are not configured in openHAB")); + return List + .of(buildCommandUsage(CMD_LIST_UNKNOWN_GA, "list group addresses which are not configured in openHAB")); } @Override diff --git a/bundles/org.openhab.binding.knx/src/main/java/org/openhab/binding/knx/internal/handler/KNXBridgeBaseThingHandler.java b/bundles/org.openhab.binding.knx/src/main/java/org/openhab/binding/knx/internal/handler/KNXBridgeBaseThingHandler.java index eda5d51e32..f59b241259 100644 --- a/bundles/org.openhab.binding.knx/src/main/java/org/openhab/binding/knx/internal/handler/KNXBridgeBaseThingHandler.java +++ b/bundles/org.openhab.binding.knx/src/main/java/org/openhab/binding/knx/internal/handler/KNXBridgeBaseThingHandler.java @@ -14,7 +14,6 @@ package org.openhab.binding.knx.internal.handler; import java.util.Map; import java.util.TreeMap; -import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.Executors; import java.util.concurrent.ScheduledExecutorService; @@ -30,9 +29,7 @@ import org.openhab.core.thing.ThingStatusDetail; import org.openhab.core.thing.binding.BaseBridgeHandler; import org.openhab.core.types.Command; -import tuwien.auto.calimero.IndividualAddress; import tuwien.auto.calimero.knxnetip.SecureConnection; -import tuwien.auto.calimero.mgmt.Destination; import tuwien.auto.calimero.secure.KnxSecureException; /** @@ -74,7 +71,6 @@ public abstract class KNXBridgeBaseThingHandler extends BaseBridgeHandler implem public record CommandExtensionData(Map unknownGA) { } - protected ConcurrentHashMap destinations = new ConcurrentHashMap<>(); private final ScheduledExecutorService knxScheduler = ThreadPoolManager.getScheduledPool("knx"); private final ScheduledExecutorService backgroundScheduler = Executors.newSingleThreadScheduledExecutor(); protected SecureRoutingConfig secureRouting; diff --git a/bundles/org.openhab.binding.knx/src/main/java/org/openhab/binding/knx/internal/i18n/KNXTranslationProvider.java b/bundles/org.openhab.binding.knx/src/main/java/org/openhab/binding/knx/internal/i18n/KNXTranslationProvider.java index c485bd834a..fa538bdca2 100644 --- a/bundles/org.openhab.binding.knx/src/main/java/org/openhab/binding/knx/internal/i18n/KNXTranslationProvider.java +++ b/bundles/org.openhab.binding.knx/src/main/java/org/openhab/binding/knx/internal/i18n/KNXTranslationProvider.java @@ -83,7 +83,7 @@ public enum KNXTranslationProvider { * translated)]), empty string for null. May possibly change in further releases. */ public String getLocalizedException(final Throwable e) { - StringBuffer res = new StringBuffer(); + StringBuilder res = new StringBuilder(); final String exName = e.getClass().getSimpleName(); final String key = "exception." + exName; final String translatedDescription = KNXTranslationProvider.I18N.get(key); -- 2.47.3