From a4f6159f091324cdcd34d284a8bca40adb7474e1 Mon Sep 17 00:00:00 2001 From: Wouter Born Date: Thu, 3 Nov 2022 22:16:07 +0100 Subject: [PATCH] [mercedesme] Fix unstable ConfigurationTest (#13650) * Make sure IPv4 is used with default callback URL * Use a more reasonable timeout Fixes #13531 Signed-off-by: Wouter Born --- .../openhab/binding/mercedesme/internal/server/Utils.java | 5 ++++- .../org/openhab/binding/mercedesme/ConfigurationTest.java | 5 +++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/bundles/org.openhab.binding.mercedesme/src/main/java/org/openhab/binding/mercedesme/internal/server/Utils.java b/bundles/org.openhab.binding.mercedesme/src/main/java/org/openhab/binding/mercedesme/internal/server/Utils.java index 0c98f72ac6..c9545dfde1 100644 --- a/bundles/org.openhab.binding.mercedesme/src/main/java/org/openhab/binding/mercedesme/internal/server/Utils.java +++ b/bundles/org.openhab.binding.mercedesme/src/main/java/org/openhab/binding/mercedesme/internal/server/Utils.java @@ -12,6 +12,7 @@ */ package org.openhab.binding.mercedesme.internal.server; +import java.net.Inet4Address; import java.net.InetAddress; import java.net.NetworkInterface; import java.net.SocketException; @@ -70,7 +71,9 @@ public class Utils { for (Enumeration addresses = iface.getInetAddresses(); addresses .hasMoreElements();) { InetAddress address = addresses.nextElement(); - return address.getHostAddress(); + if (address instanceof Inet4Address) { + return address.getHostAddress(); + } } } } diff --git a/bundles/org.openhab.binding.mercedesme/src/test/java/org/openhab/binding/mercedesme/ConfigurationTest.java b/bundles/org.openhab.binding.mercedesme/src/test/java/org/openhab/binding/mercedesme/ConfigurationTest.java index d8361a7515..7271467068 100644 --- a/bundles/org.openhab.binding.mercedesme/src/test/java/org/openhab/binding/mercedesme/ConfigurationTest.java +++ b/bundles/org.openhab.binding.mercedesme/src/test/java/org/openhab/binding/mercedesme/ConfigurationTest.java @@ -62,10 +62,11 @@ class ConfigurationTest { @Test public void testCallbackUrl() throws SocketException { String ip = Utils.getCallbackIP(); + String message = "IP " + ip + " not reachable"; try { - assertTrue(InetAddress.getByName(ip).isReachable(10)); + assertTrue(InetAddress.getByName(ip).isReachable(10000), message); } catch (IOException e) { - assertTrue(false, "IP " + ip + " not reachable"); + fail(message); } } } -- 2.47.3