From c489eef9e68a6a752bfbc29a4481156ae4874072 Mon Sep 17 00:00:00 2001
From: J-N-K <J-N-K@users.noreply.github.com>
Date: Mon, 25 Jan 2021 21:26:01 +0100
Subject: [PATCH] fix wrong unit in TotalBytes (#9954)

Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
---
 bundles/org.openhab.binding.tr064/README.md                   | 2 ++
 .../org.openhab.binding.tr064/src/main/resources/channels.xml | 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/bundles/org.openhab.binding.tr064/README.md b/bundles/org.openhab.binding.tr064/README.md
index daa270a635..e9b97d90fc 100644
--- a/bundles/org.openhab.binding.tr064/README.md
+++ b/bundles/org.openhab.binding.tr064/README.md
@@ -158,6 +158,8 @@ In this case you have to use the `wifi5GHzEnable` channel for switching the gues
 | `wanTotalBytesReceived`    | `Number:DataAmount`       |     x    | Total Bytes Received                                           |
 | `wanTotalBytesSent`        | `Number:DataAmount`       |     x    | Total Bytes Sent                                               |
  
+**Note:** AVM Fritzbox devices use 4-byte-unsigned-integers for `wanTotalBytesReceived` and `wanTotalBytesSent`, because of that the counters are reset after around 4GB data.
+
 ## `PHONEBOOK` Profile
 
 The binding provides a profile for using the FritzBox phonebooks for resolving numbers to names.
diff --git a/bundles/org.openhab.binding.tr064/src/main/resources/channels.xml b/bundles/org.openhab.binding.tr064/src/main/resources/channels.xml
index 7894074225..ba7ff1b7e9 100644
--- a/bundles/org.openhab.binding.tr064/src/main/resources/channels.xml
+++ b/bundles/org.openhab.binding.tr064/src/main/resources/channels.xml
@@ -173,13 +173,13 @@
 		<getAction name="GetCommonLinkProperties" argument="NewLayer1UpstreamMaxBitRate"/>
 	</channel>
 	<channel name="wanTotalBytesReceived" label="Total Bytes Received">
-		<item type="Number:DataAmount" unit="B" statePattern="%.3f Gio"/>
+		<item type="Number:DataAmount" unit="B" statePattern="%.3f GB"/>
 		<service deviceType="urn:dslforum-org:device:WANDevice:1"
 			serviceId="urn:WANCIfConfig-com:serviceId:WANCommonInterfaceConfig1"/>
 		<getAction name="GetTotalBytesReceived" argument="NewTotalBytesReceived"/>
 	</channel>
 	<channel name="wanTotalBytesSent" label="Total Bytes Sent">
-		<item type="Number:DataAmount" unit="B" statePattern="%.3f Gio"/>
+		<item type="Number:DataAmount" unit="B" statePattern="%.3f GB"/>
 		<service deviceType="urn:dslforum-org:device:WANDevice:1"
 			serviceId="urn:WANCIfConfig-com:serviceId:WANCommonInterfaceConfig1"/>
 		<getAction name="GetTotalBytesSent" argument="NewTotalBytesSent"/>
-- 
2.47.3