From e812d2dcbeb940286d79f035ed48a886f2aad60e Mon Sep 17 00:00:00 2001
From: Fabian Wolter <github@fabian-wolter.de>
Date: Wed, 1 May 2024 11:41:03 +0200
Subject: [PATCH] =?utf8?q?[airq]=20Add=20Hydrogen=20Sulfide=20(H=E2=82=82S?=
 =?utf8?q?)=20(#16696)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

* [airq] Add Hydrogen Sulfide (H₂S)

Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
---
 bundles/org.openhab.binding.airq/README.md    |  3 ++-
 .../binding/airq/internal/AirqHandler.java    |  1 +
 .../resources/OH-INF/i18n/airq.properties     |  2 ++
 .../resources/OH-INF/thing/thing-types.xml    | 15 +++++++++++++++
 .../main/resources/OH-INF/update/update.xml   | 19 +++++++++++++++++++
 5 files changed, 39 insertions(+), 1 deletion(-)
 create mode 100644 bundles/org.openhab.binding.airq/src/main/resources/OH-INF/update/update.xml

diff --git a/bundles/org.openhab.binding.airq/README.md b/bundles/org.openhab.binding.airq/README.md
index 1ae3c69b2b..82dc2fb331 100644
--- a/bundles/org.openhab.binding.airq/README.md
+++ b/bundles/org.openhab.binding.airq/README.md
@@ -59,6 +59,7 @@ The rw column is empty if the channel is only readable, w if the channel can be
 | dHdt                      | Number               |    | Change of Humidity                                                  |
 | dewpt                     | Number:Temperature   |    | Dew Point                                                           |
 | doorEvent                 | Number               |    | Door Event (experimental, might not work reliably)                  |
+| h2s                       | Number:Density       |    | Hydrogen sulfide (H₂S)                                              |
 | health                    | Number:Dimensionless |    | Health Index (0 to 1000, -200 for gas alarm, -800 for fire alarm)   |
 | humidityRelative          | Number:Dimensionless |    | Humidity in percent                                                 |
 | humidityAbsolute          | Number               |    | Absolute Humidity                                                   |
@@ -69,7 +70,7 @@ The rw column is empty if the channel is only readable, w if the channel can be
 | performance               | Number:Dimensionless |    | Performance Index (0 to 1000)                                       |
 | fineDustConc01            | Number               |    | Fine Dust concentration >1 µm                                       |
 | fineDustConc02_5          | Number               |    | Fine Dust concentration >2.5 µm                                     |
-| fineDustConc10            | Number               |    | Fine Dust concentration >10 µm             fni                      |
+| fineDustConc10            | Number               |    | Fine Dust concentration >10 µm                                      |
 | pressure                  | Number:Pressure      |    | Pressure                                                            |
 | so2                       | Number               |    | SO₂ concentration                                                   |
 | sound                     | Number:Dimensionless |    | Noise                                                               |
diff --git a/bundles/org.openhab.binding.airq/src/main/java/org/openhab/binding/airq/internal/AirqHandler.java b/bundles/org.openhab.binding.airq/src/main/java/org/openhab/binding/airq/internal/AirqHandler.java
index 75fc397c13..e4334788ab 100644
--- a/bundles/org.openhab.binding.airq/src/main/java/org/openhab/binding/airq/internal/AirqHandler.java
+++ b/bundles/org.openhab.binding.airq/src/main/java/org/openhab/binding/airq/internal/AirqHandler.java
@@ -464,6 +464,7 @@ public class AirqHandler extends BaseThingHandler {
             processType(decObj, "co", "co", "pair");
             processType(decObj, "co2", "co2", "pairPPM");
             processType(decObj, "dewpt", "dewpt", "pair");
+            processType(decObj, "h2s", "h2s", "pair");
             processType(decObj, "humidity", "humidityRelative", "pair");
             processType(decObj, "humidity_abs", "humidityAbsolute", "pair");
             processType(decObj, "no2", "no2", "pair");
diff --git a/bundles/org.openhab.binding.airq/src/main/resources/OH-INF/i18n/airq.properties b/bundles/org.openhab.binding.airq/src/main/resources/OH-INF/i18n/airq.properties
index 4061cddd05..69266f327f 100644
--- a/bundles/org.openhab.binding.airq/src/main/resources/OH-INF/i18n/airq.properties
+++ b/bundles/org.openhab.binding.airq/src/main/resources/OH-INF/i18n/airq.properties
@@ -67,6 +67,8 @@ channel-type.airq.dewpt_maxerr.label = Max. Error Dew Point
 channel-type.airq.dhdt.label = Change of Humidity
 channel-type.airq.door.label = Door Event (exp)
 channel-type.airq.geopos.label = Location of air-Q Device
+channel-type.airq.h2s.label = Hydrogen Sulfide (H₂S)
+channel-type.airq.h2s_maxerr.label = Max. Error H₂S Conc.
 channel-type.airq.health.label = Health Index
 channel-type.airq.humidity.label = Humidity
 channel-type.airq.humidity_abs.label = Absolute Humidity
diff --git a/bundles/org.openhab.binding.airq/src/main/resources/OH-INF/thing/thing-types.xml b/bundles/org.openhab.binding.airq/src/main/resources/OH-INF/thing/thing-types.xml
index 426a7d38c2..8ecda458a2 100644
--- a/bundles/org.openhab.binding.airq/src/main/resources/OH-INF/thing/thing-types.xml
+++ b/bundles/org.openhab.binding.airq/src/main/resources/OH-INF/thing/thing-types.xml
@@ -24,6 +24,7 @@
 			<channel id="dHdt" typeId="dhdt"/>
 			<channel id="dewpt" typeId="dewpt"/>
 			<channel id="doorEvent" typeId="door"/>
+			<channel id="h2s" typeId="h2s"/>
 			<channel id="health" typeId="health"/>
 			<channel id="humidityRelative" typeId="humidity"/>
 			<channel id="humidityAbsolute" typeId="humidity_abs"/>
@@ -53,6 +54,7 @@
 			<channel id="co_maxerr" typeId="co_maxerr"/>
 			<channel id="co2_maxerr" typeId="co2_maxerr"/>
 			<channel id="dewpt_maxerr" typeId="dewpt_maxerr"/>
+			<channel id="h2s_maxerr" typeId="h2s_maxerr"/>
 			<channel id="humidityRelative_maxerr" typeId="humidity_maxerr"/>
 			<channel id="humidityAbsolute_maxerr" typeId="humidity_abs_maxerr"/>
 			<channel id="no2_maxerr" typeId="no2_maxerr"/>
@@ -115,6 +117,7 @@
 			<property name="sensorList">Unknown sensor list</property>
 			<property name="sensorInfo">No info about sensors</property>
 			<property name="industry">No industry info</property>
+			<property name="thingTypeVersion">1</property>
 		</properties>
 
 		<config-description>
@@ -216,6 +219,12 @@
 		<state readOnly="true"></state>
 	</channel-type>
 
+	<channel-type id="h2s" advanced="false">
+		<item-type unitHint="µg/m³">Number:Density</item-type>
+		<label>Hydrogen Sulfide (H₂S)</label>
+		<state readOnly="true" pattern="%.2f %unit%"></state>
+	</channel-type>
+
 	<channel-type id="health" advanced="false">
 		<item-type>Number:Dimensionless</item-type>
 		<label>Health Index</label>
@@ -379,6 +388,12 @@
 		<state readOnly="true" pattern="± %.2f %%"></state>
 	</channel-type>
 
+	<channel-type id="h2s_maxerr" advanced="true">
+		<item-type>Number:Dimensionless</item-type>
+		<label>Max. Error H₂S Conc.</label>
+		<state readOnly="true" pattern="± %.2f %%"></state>
+	</channel-type>
+
 	<channel-type id="humidity_maxerr" advanced="true">
 		<item-type unitHint="%">Number:Dimensionless</item-type>
 		<label>Max. Error Humidity</label>
diff --git a/bundles/org.openhab.binding.airq/src/main/resources/OH-INF/update/update.xml b/bundles/org.openhab.binding.airq/src/main/resources/OH-INF/update/update.xml
new file mode 100644
index 0000000000..17176bde5d
--- /dev/null
+++ b/bundles/org.openhab.binding.airq/src/main/resources/OH-INF/update/update.xml
@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
+<update:update-descriptions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+	xmlns:update="https://openhab.org/schemas/update-description/v1.0.0"
+	xsi:schemaLocation="https://openhab.org/schemas/update-description/v1.0.0 https://openhab.org/schemas/update-description-1.0.0.xsd">
+
+	<thing-type uid="airq:airq">
+		<instruction-set targetVersion="1">
+			<add-channel id="h2s">
+				<type>airq:h2s</type>
+				<label>Hydrogen Sulfide (H₂S)</label>
+			</add-channel>
+			<add-channel id="h2s_maxerr">
+				<type>airq:h2s_maxerr</type>
+				<label>Max. Error H₂S Conc.</label>
+			</add-channel>
+		</instruction-set>
+	</thing-type>
+
+</update:update-descriptions>
-- 
2.47.3